Include PreloadHeroImage among transformers omitted for SSR #5823
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When SSR is disabled via
add_filter( 'amp_enable_ssr', '__return_false' );
I found that thedata-hero
attributes were still getting added, along with prerendering and thei-amphtml-ssr
attributes. This transformer should not be running when SSR is disabled.The result is also an invalid AMP page since it is not marked as
transformed
:Amends #5350 for #5055.
Checklist