Skip to content
Richard Braakman edited this page Oct 21, 2024 · 141 revisions

Bugs

False positives

  • GetScriptValueBreakdown is a new macro in data_binding with CK3 1.10, but it's also a defined promote and function for TopScope. Need to verify which one wins in-game, and whether it depends on the number of arguments, and fix tiger to behave the same way.
  • Don't warn for unexpected [ in @dynasty_house_unity_[HouseUnityStage.GetKey]!
  • squared_distance(prev.capital_province) uses the wrong scope for prev

Features

  • Warn about random_list in send_interface_message, because the message performs one roll and the execution performs another
  • In run_interaction, at least one of execute_threshold and send_threshold should be set.
  • localization icons can have the format @aptitude:5:inherit_color! where the aptitude icon definition declares a framesize but not a frame
  • localization can escape quotes in macros $foo|q$ (need to verify how escaping is done
  • missing effect localizations seem to have a default, where the {key}_global or {key}_first loca is used
  • the reader_export features
  • In create_character, verify that faith, culture and gender are set in some way. (Could be in the template, or via a randomization key)
  • In actions, check for duplicate events in the event tables
  • When running vic3-tiger, and the mod dir is not found, and current directory is a mod, suggest vic3-tiger .
  • In add_track_xp, check that the trait actually has a track, and that the "track" field is there if it has multiple tracks
  • Fetch the game version number from launcher/launcher-settings.json and warn if tiger's version doesn't match. (Don't consider the patchlevel though)
  • ck3: cultural parameters are localized with cultural_parameter_{key} but the key is lowercased
  • vic3: state_building_$BUILDING$_max_level_add modifiers should be dynamic based on which buildings have has_max_level
  • Do some checks on variable names: don't allow . or :
  • after doesn't get executed if there's no option (common in hidden events)
  • conf setting for --unused
  • good = yes is only for genetic traits
  • gui: "Duplicate children with the same name override previous widgets."
  • In gui, fontsize_min should be greater than 0 and less than 12
  • "Animation has more than one property specified in the animation block which is not allowed"
  • The validation errorkey is overused, and more specific errorkeys should be broken off from it.
  • Check that relation flags actually belong to the relation they are used with
  • The validations in Ideas
  • Hundreds of TODO comments in the code

Refactoring

Clone this wiki locally