Fixing preview data handling of big ints (#1950)

Signed-off-by: Kristen Armes <karmes@lyft.com>
amundsen-io · Aug 2, 2022 · 55e886b · 55e886b
1 parent a9aa1dd
commit 55e886b
Show file tree

Hide file tree

Showing 5 changed files with 29 additions and 10 deletions.
diff --git a/frontend/amundsen_application/static/.betterer.results b/frontend/amundsen_application/static/.betterer.results
@@ -418,8 +418,8 @@ exports[`eslint`] = {
       [19, 2, 8, "Assignment to function parameter \'resource\'.", "2131237679"],
       [20, 2, 248, "Expected a default case.", "1034339850"]
     ],
-    "js/ducks/tableMetadata/api/v0.ts:3505354085": [
-      [140, 23, -4358, "Expected to return a value at the end of arrow function.", "5381"]
+    "js/ducks/tableMetadata/api/v0.ts:2322129867": [
+      [142, 23, -4399, "Expected to return a value at the end of arrow function.", "5381"]
     ],
     "js/ducks/tableMetadata/owners/index.spec.ts:655040122": [
       [15, 0, 91, "\`../reducer\` import should occur before import of \`./reducer\`", "2216296793"],

diff --git a/frontend/amundsen_application/static/js/ducks/tableMetadata/api/v0.ts b/frontend/amundsen_application/static/js/ducks/tableMetadata/api/v0.ts
@@ -28,6 +28,8 @@ import {
   getTypeMetadataFromKey,
 } from './helpers';
 
+const JSONBig = require('json-bigint');
+
 export const API_PATH = '/api/metadata/v0';
 
 type MessageAPI = { msg: string };
@@ -215,6 +217,7 @@ export function getPreviewData(queryParams: TablePreviewQueryParams) {
     url: '/api/preview/v0/',
     method: 'POST',
     data: queryParams,
+    transformResponse: (data) => JSONBig.parse(data),
   })
     .then((response: AxiosResponse<PreviewDataAPI>) => ({
       data: response.data.previewData,

diff --git a/frontend/amundsen_application/static/js/features/PreviewData/index.tsx b/frontend/amundsen_application/static/js/features/PreviewData/index.tsx
@@ -12,6 +12,8 @@ import {
 
 import './styles.scss';
 
+const JSONBig = require('json-bigint');
+
 export interface PreviewDataProps {
   isLoading: boolean;
   previewData: PreviewData;
@@ -36,7 +38,7 @@ export const getSanitizedValue = (value) => {
   if (value === 0 || typeof value === 'boolean') {
     sanitizedValue = value.toString();
   } else if (typeof value === 'object') {
-    sanitizedValue = JSON.stringify(value);
+    sanitizedValue = JSONBig.stringify(value);
   } else if (typeof value === 'undefined') {
     sanitizedValue = '';
   } else {

diff --git a/frontend/amundsen_application/static/package-lock.json b/frontend/amundsen_application/static/package-lock.json
diff --git a/frontend/amundsen_application/static/package.json b/frontend/amundsen_application/static/package.json
@@ -146,6 +146,7 @@
     "form-serialize": "^0.7.2",
     "fsevents": "*",
     "jquery": "^3.5.0",
+    "json-bigint": "^1.0.0",
     "moment-timezone": "^0.5.33",
     "path-browserify": "^1.0.1",
     "process": "^0.11.10",