fix: Fix handling of big ints in preview data #1950
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kristen Armes karmes@lyft.com
Summary of Changes
The default handling of the preview data API response used
JSON.parse()
which does not handle big ints, and this resulted in loss of precision. This change makes use of the json-bigint package to parse and display the values to correctly handle any large numbers.Tests
N/A
Documentation
N/A
CheckList
Make sure you have checked all steps below to ensure a timely review.