Bug Report: Programmatic descriptions not displayed for sample data

[M0kY]

Since version 2.2.0 of amundsenfrontendlibrary programmatic descriptions do not work as per the documentation when PROGRAMMATIC_DISPLAY is left at None. After loading sample data using sample_data_loader.py no programmatic description is displayed for test_schema.test_table1.

Expected Behavior

From the documentation at https://www.amundsen.io/amundsen/frontend/docs/flask_config/

If PROGRAMMATIC_DISPLAY is left at None all added fields will show up in the order in which they were returned from the backend. Here is a screenshot of what it would look like in the bottom left:

After starting amundsen using docker-amundsen-local.yml and loading sample data I'm expecting to see the programmatic descriptions for the sample data as in the screenshot:

Current Behavior

Steps to Reproduce

1. Run amundsen using docker-amundsen-local.yml
2. Load sample data using sample_data_loader.py
3. Navigate to the test_schema.test_table1 page
4. No programmatic description is displayed

Context

Changing PROGRAMMATIC_DISPLAY from None to something else like for example:

PROGRAMMATIC_DISPLAY = {
    'test': {"display_order": 0}
}

gives the expected behavior.

Your Environment

• Amunsen version used: fd695d6

[feng-tao]

please take a look at amundsen-io/amundsendatabuilder#367 which @madison-ookla did a fix on the sample data.

[M0kY]

After updating amundsendatabuilder to the latest version the formatting of the programmatic description was fixed but the underlying issue still stands.

[madison-ookla]

@M0kY do you mind trying to run docker-amundsen.yml and confirming that the issue persists there as well?

[M0kY]

@madison-ookla docker-amundsen.yml works as expected but it uses an older version (amundsen-frontend:2.1.1) while I only noticed the issue from version 2.2.0 onward. When I upgrade the frontend version inside docker-amundsen.yml the issue occurs again.

[madison-ookla]

Got it! Thanks for clarifying 🙂

[feng-tao]

cc @ttannis hey Tamika, I know we add some configs for programmatic descriptions, do you know anything specific related to this issue?

[ttannis]

I see. We have to update the logic in https://github.com/amundsen-io/amundsenfrontendlibrary/blob/master/amundsen_application/api/utils/metadata_utils.py#L152 to account for when prog_display_config is None, and assign other = prog_descriptions in that case.

[feng-tao]

@ttannis oh i see, thanks for the info, amundsen-io/amundsenfrontendlibrary#671

[feng-tao]

@M0kY the fix is merged to master, could you try it with master and see if the issue is fixed? thanks.

[M0kY]

@feng-tao Can confirm it is now working as expected. Thanks for the quick fix.

[feng-tao]

thanks @M0kY for confirming!