Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Sample programmatic source data #367

Merged

Conversation

madison-ookla
Copy link
Contributor

Summary of Changes

Resolves amundsen-io/amundsen#674

See the details of the above issue for more context. Essentially the newline characters present in this data were being read in as two separate characters, while having them as literal newlines in the source fill allows python to correctly interpret the fields without any additional ingestion settings.

Tests

Since this is sample data I didn't modify any tests, though I did test the ingestion myself locally.

Documentation

None

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test

@madison-ookla madison-ookla requested a review from a team as a code owner September 15, 2020 18:57
Signed-off-by: Madison Bowden <madison.bowden@ookla.com>
@madison-ookla madison-ookla force-pushed the bugfix/programmatic-markdown-data branch from 533b049 to 53aaa2e Compare September 15, 2020 18:57
@feng-tao
Copy link
Member

thanks for the fix and confirmation

@feng-tao feng-tao merged commit 4f5df39 into amundsen-io:master Sep 15, 2020
@madison-ookla madison-ookla deleted the bugfix/programmatic-markdown-data branch September 15, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Newlines in sample data are not rendered properly on the front end
2 participants