Update PULL_REQUEST_TEMPLATE.md #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @verdan I've reorganized the PR template a bit to condense it into 3 main sections + the final checklist. |
danwom
approved these changes
May 2, 2019
|
Sweet !! I like that. Could you please update that in all other repos? |
Sure thing. cc @feng-tao @jinhyukchang I'll be updating the PR templates for other repos when I have some spare time. |
6 tasks
ttannis
added a commit
to amundsen-io/amundsensearchlibrary
that referenced
this pull request
May 7, 2019
### Summary of Changes This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment) ### Tests Unit tests not required for template changes. ### Documentation Documentation not required for template changes. ### CheckList Make sure you have checked **all** steps below to ensure a timely review. - [ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2" - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - [ ] PR includes a summary of changes. - [ ] PR adds unit tests, updates existing unit tests, __OR__ documents why no test additions or modifications are needed. - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - [ ] PR passes `make test` - [ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
This was referenced May 7, 2019
ttannis
added a commit
to amundsen-io/amundsensearchlibrary
that referenced
this pull request
May 7, 2019
### Summary of Changes This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment) ### Tests Unit tests not required for template changes. ### Documentation Documentation not required for template changes. ### CheckList Make sure you have checked **all** steps below to ensure a timely review. - [ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2" - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - [ ] PR includes a summary of changes. - [ ] PR adds unit tests, updates existing unit tests, __OR__ documents why no test additions or modifications are needed. - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - [ ] PR passes `make test` - [ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
dorianj
pushed a commit
to dorianj/amundsen
that referenced
this pull request
Apr 25, 2021
### Summary of Changes This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment) ### Tests Unit tests not required for template changes. ### Documentation Documentation not required for template changes. ### CheckList Make sure you have checked **all** steps below to ensure a timely review. - [ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2" - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - [ ] PR includes a summary of changes. - [ ] PR adds unit tests, updates existing unit tests, __OR__ documents why no test additions or modifications are needed. - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - [ ] PR passes `make test` - [ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
feng-tao
pushed a commit
to amundsen-io/amundsen
that referenced
this pull request
May 7, 2021
### Summary of Changes This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment) ### Tests Unit tests not required for template changes. ### Documentation Documentation not required for template changes. ### CheckList Make sure you have checked **all** steps below to ensure a timely review. - [ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2" - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - [ ] PR includes a summary of changes. - [ ] PR adds unit tests, updates existing unit tests, __OR__ documents why no test additions or modifications are needed. - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - [ ] PR passes `make test` - [ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
zacr
pushed a commit
to SaltIO/amundsen
that referenced
this pull request
May 13, 2022
### Summary of Changes This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment) ### Tests Unit tests not required for template changes. ### Documentation Documentation not required for template changes. ### CheckList Make sure you have checked **all** steps below to ensure a timely review. - [ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2" - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - [ ] PR includes a summary of changes. - [ ] PR adds unit tests, updates existing unit tests, __OR__ documents why no test additions or modifications are needed. - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - [ ] PR passes `make test` - [ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
hansadriaans
pushed a commit
to DataChefHQ/amundsen
that referenced
this pull request
Jun 30, 2022
### Summary of Changes This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment) ### Tests Unit tests not required for template changes. ### Documentation Documentation not required for template changes. ### CheckList Make sure you have checked **all** steps below to ensure a timely review. - [ ] PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2" - In case you are adding a dependency, check if the license complies with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x). - [ ] PR includes a summary of changes. - [ ] PR adds unit tests, updates existing unit tests, __OR__ documents why no test additions or modifications are needed. - [ ] In case of new functionality, my PR adds documentation that describes how to use it. - All the public functions and the classes in the PR contain docstrings that explain what it does - [ ] PR passes `make test` - [ ] I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
This PR updates the pull request template to highlight information about the PR and condense the checkpoints into a single checklist. As a reviewer I find PRs easier to review if all of the relevant content is placed together at the beginning. As a contributor I find PRs easier to submit if the checked items are condensed into one single checklist.
Copy-pasting the new template into this PR description to demo.
Tests
No tests were added -- this PR only updates the PR template and does not touch source code.
Documentation
Updated PULL_REQUEST_TEMPLATE.md
CheckList
Make sure you have checked all steps below to ensure a timely review.