Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PULL_REQUEST_TEMPLATE.md #41

Merged
merged 1 commit into from
May 7, 2019
Merged

Update PULL_REQUEST_TEMPLATE.md #41

merged 1 commit into from
May 7, 2019

Conversation

ttannis
Copy link
Contributor

@ttannis ttannis commented May 7, 2019

Summary of Changes

This PR consolidates the pull request template initially added by @verdan. It's been requested to be updated across all of our repos: amundsen-io/amundsenfrontendlibrary#125 (comment)

Tests

Unit tests not required for template changes.

Documentation

Documentation not required for template changes.

CheckList

Make sure you have checked all steps below to ensure a timely review.

  • PR title addresses the issue accurately and concisely. Example: "Updates the version of Flask to v1.0.2"
  • PR includes a summary of changes.
  • PR adds unit tests, updates existing unit tests, OR documents why no test additions or modifications are needed.
  • In case of new functionality, my PR adds documentation that describes how to use it.
    • All the public functions and the classes in the PR contain docstrings that explain what it does
  • PR passes make test
  • I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message"

@codecov-io
Copy link

codecov-io commented May 7, 2019

Codecov Report

Merging #41 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #41   +/-   ##
=======================================
  Coverage   74.76%   74.76%           
=======================================
  Files          19       19           
  Lines         939      939           
  Branches       71       71           
=======================================
  Hits          702      702           
  Misses        213      213           
  Partials       24       24

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 167677f...44055d0. Read the comment docs.

@ttannis ttannis merged commit 7dc20de into master May 7, 2019
@feng-tao feng-tao deleted the ttannis-patch-1 branch June 19, 2019 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants