Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow outputReferences to work on non-string values #1025

Merged
merged 1 commit into from
Oct 22, 2023
Merged

fix: allow outputReferences to work on non-string values #1025

merged 1 commit into from
Oct 22, 2023

Conversation

jorenbroekema
Copy link
Collaborator

Issue #, if available:

Description of changes:

  • Adds more tests to outputReferences / createPropertyFormatter
  • Allow outputReferences to work on primitives that aren't strings (but are perfectly stringifyable due to them being primitives)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jorenbroekema jorenbroekema requested a review from a team as a code owner October 12, 2023 09:22
@jorenbroekema jorenbroekema merged commit 9f2b2d2 into main Oct 22, 2023
3 checks passed
@jorenbroekema jorenbroekema deleted the outputref-non-string branch October 23, 2023 09:28
This was referenced Dec 7, 2023
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbanksdesign dbanksdesign dbanksdesign approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jorenbroekema @dbanksdesign