Work on code generation for C# / .NET (MAUI) #1162

hansmbakker · 2024-04-16T16:50:36Z

Issue #, if available: #977

Description of changes:

Export tokens to C# class format, so that they are also usable in C#, and so that you can generate compilable code. This is intended to be usable in .NET MAUI.

Support for Color
Support for numbers / dimensions
Support for string
Support for token references
Support for grouping tokens in classes, and cross-referencing them
Support for effects like shadow

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

chore: formatting-only changes for JS/MD files and pkg json

…#1014)

chore: bump husky, change precommit hook, eslint scripts

Version Packages (prerelease)

…yFormatter

V3 fixes port

Co-authored-by: Ioannis Chrysostomakis <ic768@protonmail.com>

Forward port of bugfix and grammar fix in v3

Version Packages (prerelease)

feat: add preprocessors

chore: remove es6 helpers and use actual ES6

Fix tests & slight API changes

Version Packages (prerelease)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* chore: update docs styles and migration link * chore: remove vulnerable dependencies, update contributing.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…nfiltered (amzn#1155)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

…-maui

hansmbakker · 2024-04-16T17:13:33Z

@jorenbroekema

What I am struggling with, is

style dictionary flattens everything
how can I have groups of (color) tokens that are exported to different classes, that cross-reference each other?

The use case is this:
I want to have 3 classes of color tokens:

ColorTokens: color tokens.static.text-on-bg.standard.moderate references color aliases.neutral.800
ColorAliases: color aliases.neutral.800 references primitives.grey.800
ColorPrimitives: primitives.grey.800 resolves to #525252ff

jorenbroekema · 2024-04-19T09:43:16Z

lib/common/templates/dotnet/class.cs.template.js

+ * @typedef {import('../../../../types/File.d.ts').File} File
+ * @typedef {import('../../../../types/Config.d.ts').LocalOptions} LocalOptions
+ */
+


This looks great!

jorenbroekema · 2024-04-19T09:45:06Z

package.json

@@ -157,5 +157,13 @@
    "unist-util-visit": "^5.0.0",
    "uuid": "^9.0.1",
    "yaml": "^2.3.4"
+  },
+  "mocha": {


Ah cool, then we can also remove these params in the scripts['test:node'] for brevity right?

jorenbroekema · 2024-04-19T09:45:48Z

It sounds like what you're looking for is something that is similar to outputReferences, this feature is theoretically implementable in any format but it's not super trivial to do it. I see that you're reusing createPropertyFormatter which has an implementation for outputReferences which is great, that definitely helps a lot, is there something that you feel is missing from that?

jorenbroekema · 2024-04-19T09:49:34Z

__tests__/common/formatHelpers/setCSharpFileProperties.test.js

+        const file = setCSharpFileProperties({
+          accessModifier: 'public',
+        });
+        expect(file.accessModifier).to.equal('public ');


Suggested change

expect(file.accessModifier).to.equal('public ');

expect(file.accessModifier).to.equal('public');

I think it's better to add the needed whitespace later in the format itself rather than doing it here. A few days ago I refactored all of the existing templates and also this file: https://github.com/amzn/style-dictionary/blob/v4/lib/common/formatHelpers/setSwiftFileProperties.js#L50 and then add the whitespacing here: https://github.com/amzn/style-dictionary/blob/v4/lib/common/templates/ios-swift/any.swift.template.js#L24

jorenbroekema · 2024-04-19T09:49:58Z

lib/common/formatHelpers/setCSharpFileProperties.js

+ */
+export default function setCSharpFileProperties(options) {
+  if (typeof options.accessModifier === 'undefined') {
+    options.accessModifier = 'public ';


Suggested change

options.accessModifier = 'public ';

options.accessModifier = 'public';

jorenbroekema · 2024-04-19T09:50:09Z

lib/common/formatHelpers/setCSharpFileProperties.js

+    options.accessModifier = 'public ';
+  } else {
+    if (options.accessModifier !== '') {
+      options.accessModifier = `${options.accessModifier} `;


Suggested change

options.accessModifier = `${options.accessModifier} `;

options.accessModifier = `${options.accessModifier}`;

jorenbroekema · 2024-04-19T09:52:45Z

I reviewed your PR thusfar and it looks great! let me know if there's anything I can help with, you can also reach me on Slack if you wanna have a call at some point to flesh out some of the details

jorenbroekema and others added 30 commits September 15, 2023 16:55

chore: formatting-only changes for JS/MD files and pkg json

4140de9

Merge pull request amzn#1013 from amzn/formatting

c5a9592

chore: formatting-only changes for JS/MD files and pkg json

chore: formatting createPropertyFormatter test/code

d043139

chore: add verify & release workflows (amzn#1018)

7d2310c

BREAKING: make style-dictionary ESM-only and browser-compatible (amzn…

dcbe2fb

…#1014)

chore: bump husky, change precommit hook, eslint scripts

a45ac2f

Merge pull request amzn#1028 from amzn/fix-husky-eslint

4d82091

chore: bump husky, change precommit hook, eslint scripts

chore: customize commit message changesets workflow

e43b147

chore: release (prerelease)

016ac6b

Merge pull request amzn#1029 from amzn/changeset-release/v4

dab4161

Version Packages (prerelease)

fix: allow outputReferences to work on non-string values

24d41c3

feat: commentStyle and commentPosition improvements for createPropert…

c1dd5ec

…yFormatter

Merge pull request amzn#1030 from amzn/v3-fixes-port

ddafafe

V3 fixes port

fix: allow falsy token values for outputReferences, e.g. 0

6fb81ad

chore: fix grammar issue in docs

6495951

Co-authored-by: Ioannis Chrysostomakis <ic768@protonmail.com>

Merge pull request amzn#1035 from amzn/port-ref-falsy

39c0c97

Forward port of bugfix and grammar fix in v3

chore: release (prerelease)

6c0ac72

Merge pull request amzn#1031 from amzn/changeset-release/v4

0d3531c

Version Packages (prerelease)

chore: fix unit tests

1e19133

fix: logging to respect log level option, fix integration tests

984a71e

fix: add commentPosition to FormatHelpers.LineFormatting type interface

fd8c3b5

chore: add changesets

a4542f4

chore: remove es6 helpers and use actual ES6

3a380a6

feat: add preprocessors

cedf8a0

Merge pull request amzn#1043 from amzn/preprocessors

82e4975

feat: add preprocessors

Merge pull request amzn#1048 from amzn/es6-remove

e2493fb

chore: remove es6 helpers and use actual ES6

Merge pull request amzn#1045 from amzn/fix-tests

269c077

Fix tests & slight API changes

chore: release (prerelease)

2b62332

Merge pull request amzn#1050 from amzn/changeset-release/v4

efbfeee

Version Packages (prerelease)

chore: fix inject-version script

3591f50

github-actions bot and others added 15 commits April 5, 2024 11:40

chore: release (prerelease) (amzn#1146)

27d0622

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

chore: add migration docs (amzn#1148)

0b47321

Some small docs fixes, and removing docsify (amzn#1149)

6254532

* chore: update docs styles and migration link * chore: remove vulnerable dependencies, update contributing.md

fix: change merging behavior for tokens to override (amzn#1151)

47face0

fix: asset url handling in CSS format (amzn#1153)

0b81a08

feat: add outputReferencesTransformed utility function (amzn#1154)

2da5130

chore: release (prerelease) (amzn#1152)

50a69dc

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

fix: outputReferencesTransformed util handling object-value tokens, u…

061c67e

…nfiltered (amzn#1155)

chore: fix some docs links (amzn#1159)

51efc17

fix: logging to be in sequence per platform (amzn#1161)

6cfce97

fix: get rid of lodash, refactor templates to ES6 (amzn#1160)

3485467

chore: release (prerelease) (amzn#1157)

76d5ab4

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

feat: initial commit for colors with dotnet

22c307e

chore: add gitattributes to ensure consistent file handling

908c413

Merge remote-tracking branch 'origin/v4' into feature/generate-dotnet…

bdba43e

…-maui

hansmbakker requested a review from a team as a code owner April 16, 2024 16:50

hansmbakker mentioned this pull request Apr 16, 2024

Design Tokens (json) → XAML (for .NET MAUI) #977

Open

hansmbakker changed the base branch from main to v4 April 16, 2024 17:06

hansmbakker mentioned this pull request Apr 16, 2024

RFC: What would you like to see in Style Dictionary 4.0?👩🏽‍💻💡 #643

Closed

jorenbroekema reviewed Apr 19, 2024

View reviewed changes

jorenbroekema force-pushed the v4 branch from 7929e70 to 2253a56 Compare June 28, 2024 13:23

jorenbroekema deleted the branch amzn:v4 June 28, 2024 23:09

jorenbroekema closed this Jun 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Work on code generation for C# / .NET (MAUI) #1162

Work on code generation for C# / .NET (MAUI) #1162

hansmbakker commented Apr 16, 2024 •

edited

Loading

hansmbakker commented Apr 16, 2024

jorenbroekema Apr 19, 2024

jorenbroekema Apr 19, 2024

jorenbroekema commented Apr 19, 2024

jorenbroekema Apr 19, 2024

jorenbroekema Apr 19, 2024

jorenbroekema Apr 19, 2024

jorenbroekema commented Apr 19, 2024

	expect(file.accessModifier).to.equal('public ');
	expect(file.accessModifier).to.equal('public');

	options.accessModifier = 'public ';
	options.accessModifier = 'public';

	options.accessModifier = `${options.accessModifier} `;
	options.accessModifier = `${options.accessModifier}`;

Work on code generation for C# / .NET (MAUI) #1162

Work on code generation for C# / .NET (MAUI) #1162

Conversation

hansmbakker commented Apr 16, 2024 • edited Loading

hansmbakker commented Apr 16, 2024

jorenbroekema Apr 19, 2024

Choose a reason for hiding this comment

jorenbroekema Apr 19, 2024

Choose a reason for hiding this comment

jorenbroekema commented Apr 19, 2024

jorenbroekema Apr 19, 2024

Choose a reason for hiding this comment

jorenbroekema Apr 19, 2024

Choose a reason for hiding this comment

jorenbroekema Apr 19, 2024

Choose a reason for hiding this comment

jorenbroekema commented Apr 19, 2024

hansmbakker commented Apr 16, 2024 •

edited

Loading