fix: support convert binary files to b64 #1364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
jorenbroekema
force-pushed
the
convert-binaries
branch
3 times, most recently
from
5ff8a9f
to
2737ce9
Compare
jorenbroekema
force-pushed
the
convert-binaries
branch
from
2737ce9
to
5b80939
Compare
dbanksdesign
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
closes #1360
This may be interesting to someone, but I used Claude to spar about this topic https://claude.ai/chat/93ca0bbc-051f-42ab-926f-5e5eaf0f0c55 and go from my initial code snippet, to eventually a better version of it. Also helped me understand some things about buffers :)
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.