Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makefile: update deprecated option #1595

Closed
wants to merge 1 commit into from
Closed

Makefile: update deprecated option #1595

wants to merge 1 commit into from
+1 −1

Conversation

vargenau
Copy link
Contributor

goreleaser release --rm-dist --> goreleaser release --clean

See: https://goreleaser.com/deprecations/#-rm-dist

@vargenau
Makefile: update deprecated option
2e6d476 
goreleaser release --rm-dist --> goreleaser release --clean

See: https://goreleaser.com/deprecations/#-rm-dist

Signed-off-by: Marc-Etienne Vargenau <marc-etienne.vargenau@nokia.com>
@spiffcs
Copy link
Contributor

spiffcs commented Feb 27, 2023 •
edited
Loading

Thanks for the PR @vargenau -- I'm not sure why these CI checks are failing and was unable to checkout/modify this patch:

#1629 <-- This PR provides the same change without the CI failure so I'll get it merged -- sorry again for not being able to resolve your branch

@spiffcs spiffcs closed this Feb 27, 2023
@vargenau
Copy link
Contributor Author

No issue. I did not understand either why tests failed with such a minor change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vargenau @spiffcs