Upgrade nix to 0.28 #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreacorbellini
requested changes
Feb 29, 2024
|
Whoops, haha -- should have tested there! I usually do my dev on Linux, but was on illumos while debugging this. |
|
Sorry, looks like the CI is failing due to linting. If you run |
|
My bad! I was editing using raw vim rather than vscode for $reasons. Would you be willing to change the "require approval" setting to make it so that it only applies to users not new to GitHub?
|
|
Thank you! Wondering if you can get a release out soon. |
|
Hi, yes, these days I'm very time constrained but I'll try to get it out
this weekend.
…On Fri, Mar 1, 2024, 11:08 Rain ***@***.***> wrote:
Thank you! Wondering if you can get a release out soon.
—
Reply to this email directly, view it on GitHub
<#5 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AACOKLQPDSQU4THV3LWPQQDYWDGZFAVCNFSM6AAAAABD7HJ6DCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNZTG43DKNZSGI>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***
com>
|
|
Version 0.1.3 is now published with your changes: https://crates.io/crates/atomic-write-file/0.1.3. Enjoy, and thanks again for your contribution! |
|
Appreciate it! Thanks again for being so responsive :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for maintaining this crate! Sending a PR to update nix to the latest version, so it picks up (in particular) nix-rust/nix#2275.
Thanks!