Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OFlag::O_DIRECTORY for Solarish #2275

Merged
merged 3 commits into from
Dec 27, 2023
Merged

Enable OFlag::O_DIRECTORY for Solarish #2275

merged 3 commits into from
Dec 27, 2023

Conversation

travispaul
Copy link
Contributor

@travispaul travispaul commented Dec 26, 2023 •
edited
Loading

What does this PR do

Allows O_DIRECTORY to be used on illumos and Solaris.

Confirmed that O_DIRECTORY was defined on Solaris (confirmed on at least 11.4) and illumos (added via illumos bug 9965 in early 2020)

See discussion on: /issues/2273

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@travispaul
Copy link
Contributor Author

Ran unit tests on SmartOS (base-64-lts 22.4.0) and there are currently four failing tests:

  • sys::test_termios::test_local_flags
  • test_stat::test_mknod
  • test_pty::test_read_ptty_pair
  • test_unistd::test_ttyname

These however were failing before these changes.

SteveLauC
SteveLauC reviewed Dec 27, 2023
View reviewed changes
changelog/2275.changed.md Outdated
@@ -0,0 +1 @@
No longer omit `O_DIRECTORY` for Solarish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a new feature, we should probably change it to:

2275.added.md

Enable `OFlag::O_DIRECTORY` for Solarish

@travispaul travispaul changed the title No longer omit O_DIRECTORY for Solarish Enable Oflag::O_DIRECTORY for Solarish Dec 27, 2023
@SteveLauC
Copy link
Member

BTW, should we close #2273?

@travispaul travispaul changed the title Enable Oflag::O_DIRECTORY for Solarish Enable OFlag::O_DIRECTORY for Solarish Dec 27, 2023
SteveLauC
SteveLauC approved these changes Dec 27, 2023
View reviewed changes
Copy link
Member

@SteveLauC SteveLauC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SteveLauC SteveLauC added this pull request to the merge queue Dec 27, 2023
Merged via the queue into nix-rust:master with commit 4e2d917 Dec 27, 2023
35 checks passed
@travispaul travispaul mentioned this pull request Dec 27, 2023
Closed
@sunshowers sunshowers mentioned this pull request Feb 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SteveLauC SteveLauC SteveLauC approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@travispaul @SteveLauC