Skip to content
This repository has been archived by the owner on Oct 15, 2024. It is now read-only.

Use remembered credential even if it is empty #880

Merged
merged 9 commits into from
Jun 26, 2020
Merged

Use remembered credential even if it is empty #880

merged 9 commits into from
Jun 26, 2020

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Jun 23, 2020

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates

📜 Description

Use the remembered credential even if it is empty.

💡 Motivation and Context

Should fix #875.

💚 How did you test it?

Can't test right now, but am quite positive that this is the fix.

📝 Checklist

  • I formatted the code with the IDE's reformat action (Ctrl + Shift + L/Cmd + Shift + L)
  • I reviewed submitted code
  • I added a CHANGELOG entry if applicable

🔮 Next steps

📸 Screenshots / GIFs

@fmeum fmeum mentioned this pull request Jun 23, 2020
Closed
@msfjarvis msfjarvis added this to the 1.9.1 milestone Jun 24, 2020
@fmeum
Copy link
Member Author

fmeum commented Jun 24, 2020

I confirmed that this fixes the issue. Should we revert e1f81e8 before releasing 1.9.1?

@msfjarvis
Copy link
Member

I was gonna pitch a new branching and versioning system anyway so might as well. How about we split off a new branch from v1.9.0 called release, rename master to develop and then backport patches from develop to the release branch for our patch releases? Tags will continue pointing to the right commits so merging release back into develop won't be a problem.

@fmeum
Copy link
Member Author

fmeum commented Jun 24, 2020

Sounds good. I won't be able to do this today and maybe not even tomorrow, but I would have proposed something very similar.

@msfjarvis
Copy link
Member

Sounds good. I won't be able to do this today and maybe not even tomorrow, but I would have proposed something very similar.

Yeah no problem, I'll do it in a couple hours.

@msfjarvis msfjarvis closed this Jun 24, 2020
@msfjarvis msfjarvis reopened this Jun 24, 2020
@msfjarvis msfjarvis changed the base branch from master to develop June 24, 2020 19:01
@msfjarvis
Copy link
Member

Okay I unfucked the PR situation and I think we're good to go now.

@msfjarvis
Merge branch 'develop' into FabianHenneke-patch-1
8c79b8d 
* develop:
  github: update actions for updated branching logic
@msfjarvis
Copy link
Member

Generated another key with -m PEM, gave it an empty passphrase and wasn't prompted on subsequent operations so I guess we're good to go.

@msfjarvis
Update relnotes
c11c590 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@msfjarvis msfjarvis self-assigned this Jun 24, 2020
msfjarvis
msfjarvis previously approved these changes Jun 24, 2020
View reviewed changes
@msfjarvis
Reword relnotes
13ad271 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
msfjarvis previously approved these changes Jun 24, 2020
View reviewed changes
fmeum
fmeum commented Jun 24, 2020
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@msfjarvis
2019 it is
fd2d9c2 
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
@fmeum fmeum merged commit b60c5fb into develop Jun 26, 2020
@fmeum fmeum deleted the FabianHenneke-patch-1 branch June 26, 2020 07:12
@msfjarvis msfjarvis mentioned this pull request Jun 26, 2020
Merged
6 tasks
msfjarvis added a commit that referenced this pull request Jun 27, 2020
@msfjarvis
Merge branch 'develop' into feature/configure-pull-behavior
51ab89b 
* develop: (24 commits)
  UI fixups (#892)
  Update Public Suffix List data (#888)
  Use remembered credential even if it is empty (#880)
  Reset SSH passphrase after SSH key import (#885)
  Prevent cached passwords from being wiped (#884)
  build: uprev all dependencies (#882)
  github: update actions for updated branching logic
  Use a custom sshj config (#878)
  Remove API 30 from pull request test matrix (#879)
  Add Google Play/F-Droid badges to the README (#877)
  Retire Android Arsenal badge (#876)
  Add paragraphs to F-Droid summary (#874)
  Replace YAML with HTML in F-Droid fastlane summary (#873)
  Add relnotes for #871 (#872)
  Add org.gnu.icecat as a trusted multi-origin browser (#871)
  README: re-add F-Droid (#870)
  build: prepare next development version
  build: bump version to 1.9.0
  Prepare release 1.9.0
  PasswordCreationActivity: properly guard rename code
  ...

Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis added a commit that referenced this pull request Jul 1, 2020
@msfjarvis
Merge branch 'develop' into feature/autofill_sms_otp
8bcc2da 
* develop:
  Scroll to files and enter folders when created (#909)
  Run a treewide reformat (#908)
  Improve how secrets and stored and used (#907)
  Improve and refactor Autofill heuristics (#905)
  Use PreferenceKeys file to manage SharedPreferences keys. (#891)
  Bump version
  Prepare release 1.9.2
  update changelog
  Workaround to prevent crash on first run (#898)
  build: bump version
  Prepare release 1.9.1
  Backport Actions fixes (#894)
  Remove API 30 from pull request test matrix (#879)
  CHANGELOG: reword to better clarify fixes
  Prevent cached passwords from being wiped (#884)
  Use remembered credential even if it is empty (#880)
  Reset SSH passphrase after SSH key import (#885)
  Add relnotes for #871 (#872)
  Add org.gnu.icecat as a trusted multi-origin browser (#871)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@msfjarvis msfjarvis msfjarvis approved these changes

@Skrilltrax Skrilltrax Awaiting requested review from Skrilltrax

Assignees

@msfjarvis msfjarvis

Labels
None yet
Projects
None yet
Milestone
1.9.1
Development

Successfully merging this pull request may close these issues.

[Bug] Remember ssh key passphrase
3 participants
@fmeum @msfjarvis @FabianHenneke