UI fixups #892
UI fixups #892
Conversation
Without this we'd have overlapping password toggle and error drawable icons. This issue was triggered because of Kotlin converting `setError` to its property syntax. That caused things to be delegated to platform `TextView`'s `setError(String)` method as opposed to `TextInputEditText`'s `setError(String, Drawable)`. Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
This would previously get laid under the child count and folder indicator icon. Now it will eagerly split into separate lines as soon as it reaches the child count view Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
|
Looks good but that error prompt isn't a part of Material 2.0. Shouldn't we use the material components? |
What's the MDC equivalent? |
https://material.io/components/images/content/bd72a300ee8c3236b48ee86d5c7824c7.png |
Tried setting Screenshot
|
Yeah, I guess you'll manually have to disable and enable view password toggle in case of an error. I don't have many issues with the new tooltip. |
* develop: (24 commits) UI fixups (#892) Update Public Suffix List data (#888) Use remembered credential even if it is empty (#880) Reset SSH passphrase after SSH key import (#885) Prevent cached passwords from being wiped (#884) build: uprev all dependencies (#882) github: update actions for updated branching logic Use a custom sshj config (#878) Remove API 30 from pull request test matrix (#879) Add Google Play/F-Droid badges to the README (#877) Retire Android Arsenal badge (#876) Add paragraphs to F-Droid summary (#874) Replace YAML with HTML in F-Droid fastlane summary (#873) Add relnotes for #871 (#872) Add org.gnu.icecat as a trusted multi-origin browser (#871) README: re-add F-Droid (#870) build: prepare next development version build: bump version to 1.9.0 Prepare release 1.9.0 PasswordCreationActivity: properly guard rename code ... Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
|
|
|
Cool, the earlier one was better anyway. |
📢 Type of change
📜 Description
Fixes folder label not wrapping off at the correct bounds and the error drawable for wrong password overlapping the
view password icon.
💡 Motivation and Context
The first bug was reported to me by @xdevs23 and the second one was pointed out by @FabianHenneke
💚 How did you test it?
Visual verification
📝 Checklist
📸 Screenshots / GIFs
Before
After