This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Migrate to ActivityResultContracts #910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
I don't want to ever touch these files Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
|
@FabianHenneke this did resolve our problem with sync not calling |
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
|
I'm not going to touch the legacy Autofill implementation, and I can't think of a good way to eliminate the onActivityResult in |
msfjarvis
changed the title
- Silently delete empty directory - Always refresh password list upon completion Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Me neither, we can tackle it some time after the GitAsyncTask migration. |
* develop: Fill OTP fields with SMS codes (#900)
|
@FabianHenneke this is good to go, I don't see anything I'd like to change. |
fmeum
reviewed
Jul 2, 2020
* develop: release: script improvements (#915)
fmeum
approved these changes
Jul 3, 2020
msfjarvis
added a commit
to fmeum/Android-Password-Store
that referenced
this pull request
Jul 14, 2020
* develop: (77 commits) Add debug icon and update color palette (android-password-store#931) Revert "Work around Chrome Autofill issue (android-password-store#921)" (android-password-store#933) github: remove freeDebug variant from pull request matrix (android-password-store#932) Properly guard against invalid renaming (android-password-store#929) Fix navigation bar theming and reformat (android-password-store#930) Exclude third_party scope from reformats (android-password-store#927) Move password export to the IO dispatcher (android-password-store#918) Mention android-password-store#482 being fixed in the changelog (android-password-store#925) global: set an import order rule and reformat with it (android-password-store#924) styles: re-add alertDialogTheme override (android-password-store#923) Work around Chrome Autofill issue (android-password-store#921) Major UI overhaul and the introduction of a new icon (android-password-store#920) Update Public Suffix List data (android-password-store#917) Migrate to ActivityResultContracts (android-password-store#910) release: script improvements (android-password-store#915) Deploy both variants to snapshot directory (android-password-store#914) Fill OTP fields with SMS codes (android-password-store#900) Fix up URIish instances with @ in user name (android-password-store#913) build: upgrade Gradle wrapper (android-password-store#911) Scroll to files and enter folders when created (android-password-store#909) ... Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Migrates
somenearly all uses ofsetTargetFragmentandstartActivityForResulttoActivityResultContracts.💡 Motivation and Context
ActivityResultContractsis a cleaner and more effective abstraction and supports a lot more things than juststartActivityForResultOOTB.💚 How did you test it?
Manually verify app works as before
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs