This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Move password export to the IO dispatcher #918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
|
Can you reduce ProgressBar size a bit. That doesn't look good imo. |
|
Also doing this is |
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
|
Removed the progressbar. The export will fail if the activity dies so I've added some workarounds to prevent the user from killing it. |
* develop: global: set an import order rule and reformat with it (#924) Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
msfjarvis
commented
Jul 8, 2020
|
I've tested on API 29 and it was working fine. I'll test on emulator. |
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
|
@msfjarvis can you test it again? |
Works now, but the icon needs to be changed. Try this. |
Signed-off-by: Aditya Wasan <adityawasan55@gmail.com>
|
LGTM, approve and submit once presubmit runs finish. |
fmeum
suggested changes
Jul 9, 2020
app/src/main/java/mozilla/components/lib/publicsuffixlist/PublicSuffixListData.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
fmeum
approved these changes
Jul 9, 2020
msfjarvis
added a commit
that referenced
this pull request
Jul 9, 2020
* develop: Move password export to the IO dispatcher (#918)
msfjarvis
added a commit
to fmeum/Android-Password-Store
that referenced
this pull request
Jul 14, 2020
* develop: (77 commits) Add debug icon and update color palette (android-password-store#931) Revert "Work around Chrome Autofill issue (android-password-store#921)" (android-password-store#933) github: remove freeDebug variant from pull request matrix (android-password-store#932) Properly guard against invalid renaming (android-password-store#929) Fix navigation bar theming and reformat (android-password-store#930) Exclude third_party scope from reformats (android-password-store#927) Move password export to the IO dispatcher (android-password-store#918) Mention android-password-store#482 being fixed in the changelog (android-password-store#925) global: set an import order rule and reformat with it (android-password-store#924) styles: re-add alertDialogTheme override (android-password-store#923) Work around Chrome Autofill issue (android-password-store#921) Major UI overhaul and the introduction of a new icon (android-password-store#920) Update Public Suffix List data (android-password-store#917) Migrate to ActivityResultContracts (android-password-store#910) release: script improvements (android-password-store#915) Deploy both variants to snapshot directory (android-password-store#914) Fill OTP fields with SMS codes (android-password-store#900) Fix up URIish instances with @ in user name (android-password-store#913) build: upgrade Gradle wrapper (android-password-store#911) Scroll to files and enter folders when created (android-password-store#909) ... Signed-off-by: Harsh Shandilya <me@msfjarvis.dev>
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
Makes password export asynchronous and adds some UI feedback to make it visible to the user that something is happening in the background.
💡 Motivation and Context
Exporting stores with a large number of directories/files (~100? maybe even lesser?) causes the app to stall and freeze until the copy task is complete.
💚 How did you test it?
Manually exported passwords multiple times and the app did not freeze.
📝 Checklist
🔮 Next steps
📸 Screenshots / GIFs