Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing: Remove Unused If-Else condition #884

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

sparrow007
Copy link
Contributor

Fix #883

Just removed the unused if-else condition.

@sparrow007 sparrow007 requested a review from a team as a code owner July 11, 2022 20:41
@IanGClifton IanGClifton requested review from astamato and removed request for IanGClifton July 16, 2022 00:18
Copy link
Contributor

@Gurupreet Gurupreet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, may be @astamato can confirm as well if surface is for both selected and unselected state for the field.

@astamato astamato merged commit 815346b into android:main Aug 22, 2022
vfishv added a commit to vfishv/compose-samples that referenced this pull request Sep 25, 2022
* commit '5bc3451b11f9aae111b8a6dca0199a317c997a2b': (331 commits)
  Updating to safe flow collection with collectAsStateWithLifecycle() (android#970)
  [Jetsurvey] Converted to use Material 3 (android#954)
  [JetNews] Remove invalid comment (android#966)
  [Jetnews] Update to Material3 (android#964)
  Compose latest (android#961)
  Disable auto creation of deps PRs for renovate (android#960)
  Version Catalog support  (android#950)
  Fixing: Remove Unused If-Else condition (android#884)
  [Jetcaster] Fix recomposition loop in verticalGradientScrim (android#946)
  Fix readme image size (android#926)
  Fix a11y bugs (android#914)
  Update Androidx Lifecycle deps to v2.5.1 (android#932)
  Update plugin com.android.test to v7.2.2 (android#931)
  [Crane] Fix destinations not in list issue. (android#938)
  Update main | Compose 1.2.1 | Compiler 1.3.0 | Kotlin 1.7.10 (android#924)
  Update accompanist_version to v0.25.1
  added licence to shapes
  added shapes for material
  Added a fix to not show back button on permanent drawer, added Material shapes
  [All] Updating to Compose 1.2 (android#905)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[JetChat] No need of If else condition In UserInput.kt
3 participants