Updating to safe flow collection with collectAsStateWithLifecycle() #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astamato
requested review from
JolandaVerhoef,
manuelvicnt,
ricknout and
riggaroo
and removed request for
JolandaVerhoef
riggaroo
reviewed
Sep 1, 2022
| @@ -8,6 +8,7 @@ androidx-benchmark-junit4 = "1.1.0-beta04" | |||
| androidx-constraintlayout = "1.0.1" | |||
| androidx-corektx = "1.8.0" | |||
| androidx-lifecycle-compose = "2.5.1" | |||
| androidx-lifecycle-runtime-compose = "2.6.0-alpha01" | |||
There was a problem hiding this comment.
Which version of Compose does this bring in? :) because we are aiming to depend on compose stable on main
There was a problem hiding this comment.
+--- androidx.lifecycle:lifecycle-runtime-compose:2.6.0-alpha01
| +--- androidx.compose.ui:ui:1.0.1 -> 1.2.1 (*)
riggaroo
approved these changes
Sep 1, 2022
manuelvicnt
approved these changes
Sep 2, 2022
vfishv
added a commit
to vfishv/compose-samples
that referenced
this pull request
Sep 25, 2022
* commit '5bc3451b11f9aae111b8a6dca0199a317c997a2b': (331 commits) Updating to safe flow collection with collectAsStateWithLifecycle() (android#970) [Jetsurvey] Converted to use Material 3 (android#954) [JetNews] Remove invalid comment (android#966) [Jetnews] Update to Material3 (android#964) Compose latest (android#961) Disable auto creation of deps PRs for renovate (android#960) Version Catalog support (android#950) Fixing: Remove Unused If-Else condition (android#884) [Jetcaster] Fix recomposition loop in verticalGradientScrim (android#946) Fix readme image size (android#926) Fix a11y bugs (android#914) Update Androidx Lifecycle deps to v2.5.1 (android#932) Update plugin com.android.test to v7.2.2 (android#931) [Crane] Fix destinations not in list issue. (android#938) Update main | Compose 1.2.1 | Compiler 1.3.0 | Kotlin 1.7.10 (android#924) Update accompanist_version to v0.25.1 added licence to shapes added shapes for material Added a fix to not show back button on permanent drawer, added Material shapes [All] Updating to Compose 1.2 (android#905) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.