Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gmd #1208

Closed
wants to merge 20 commits into from
Closed

Add gmd #1208

wants to merge 20 commits into from

Conversation

AndreSand
Copy link

@AndreSand AndreSand commented Feb 7, 2024

Thanks for submitting a pull request. Please include the following information.

What I have done and why
Include a summary of what your pull request contains, and why you have made these changes.
Add GMD back

  • Using AGP 8.4.1
  • Using Gradle wrapper to 8.7

#1107

Fixes #1107

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Is this your first pull request?

AndreSand and others added 3 commits December 20, 2023 10:59
Try to update local fork
Update main branch fork
- Using Android Studio Jellyfish canary 8
- Update AGP to 8.4.0-alpha07 from 8.2.0
- Update Gradle wrapper to 8.6-rc-1 from 8.5

android#1107
@AndreSand AndreSand changed the title Andres/add gmd Add gmd Feb 7, 2024
AndreSand and others added 2 commits February 8, 2024 09:44
Co-authored-by: Mercury Li <lihenggui@users.noreply.github.com>
.github/workflows/Build.yaml Outdated Show resolved Hide resolved
.github/workflows/Build.yaml Outdated Show resolved Hide resolved
@AndreSand AndreSand marked this pull request as ready for review February 13, 2024 05:38
@AndreSand AndreSand marked this pull request as draft February 13, 2024 05:41
@JoseAlcerreca
Copy link
Contributor

@AndreSand please update the description of the PR

@Jaehwa-Noh
Copy link
Contributor

Jaehwa-Noh commented Jun 11, 2024

There's no chance GMD to covers the lower API.
https://developer.android.com/studio/test/gradle-managed-devices

This feature, available for API levels 27 and higher,

I think we should remain the androidTest for lower api.

@AndreSand AndreSand requested a review from JoseAlcerreca July 16, 2024 00:26
@keyboardsurfer
Copy link
Member

We just landed a functioning GMD config. If this PR is still active please let us know. Otherwise we'll close it soon.

@keyboardsurfer
Copy link
Member

Thank you for submitting this pull request. We have decided not to accept it at this time.
Feel free to comment or open an issue for further discussion if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Try out AGP alpha17 with GMD
6 participants