Replace testharness with DeviceConfigurationOverride

[sanao1006]

What I have done and why
Replace testharness with DeviceConfigurationOverride.
This is because accompanist/testharness is deprecated.

ref: https://google.github.io/accompanist/testharness/

**This library is deprecated, with a superseding version in androidx.compose.ui.test.

Fixes #1201

[alexvanyo]

One small comment on the version, and it looks like CI is failing. Do the tests pass locally for you?

[sanao1006]

I have no idea what causes the java.lang.NoSuchMethodError: No static method ... error on the Instrument test.
https://github.com/android/nowinandroid/actions/runs/8005993030/job/21873328665?pr=1221

java.lang.NoSuchMethodError: No static method getAllSemanticsNodes(Landroidx/compose/ui/semantics/SemanticsOwner;ZZ)Ljava/util/List; in class Landroidx/compose/ui/semantics/SemanticsOwnerKt; or its super classes (declaration of 'androidx.compose.ui.semantics.SemanticsOwnerKt' appears in /data/app/~~e8B0qmOuMalVgsWU1kGVrg==/com.google.samples.apps.nowinandroid.demo.debug-9YEXqTHbjJ2K4mFxOY4hUw==/base.apk!classes11.dex)

java.lang.NoSuchMethodError: No static method CompositionLocalProvider(Landroidx/compose/runtime/ProvidedValue;Lkotlin/jvm/functions/Function2;Landroidx/compose/runtime/Composer;I)V in class Landroidx/compose/runtime/CompositionLocalKt; or its super classes (declaration of 'androidx.compose.runtime.CompositionLocalKt' appears in /data/app/~~e8B0qmOuMalVgsWU1kGVrg==/com.google.samples.apps.nowinandroid.demo.debug-9YEXqTHbjJ2K4mFxOY4hUw==/base.apk)

Is it due to dependence?
Do you have any idea what it is?

[alexvanyo]

It seems like the 1.7.x version of the ui-test is expecting methods from a newer version of the main ui library. Due to how main and test dependencies resolve, sometimes adding a new dependency in the test library won't transitively bump the main ui library to the needed version.

#1220 will update our Compose dependencies from 1.5.x to 1.6.x which may resolve the issue. If it doesn't, then the other option is to update to the 1.7.x version of Compose throughout the project so that the version is aligned between the main dependencies and the test dependencies.

[dturner]

Hi @sanao1006, many thanks for submitting this PR. Unfortunately I already had a branch with this change in it ready to go (plus some slight cosmetic differences e.g. version catalog naming) so I will merge this PR instead when we're ready.

[dturner]

I do have some questions/comments on @alexvanyo's comment though:

Due to how main and test dependencies resolve, sometimes adding a new dependency in the test library won't transitively bump the main ui library to the needed version

Could you elaborate more on this? Why doesn't ui-test:1.7.x have a strict dependency on ui:1.6.x minimum?

#1220 will update our Compose dependencies from 1.5.x to 1.6.x which may resolve the issue.

Yes, it does resolve the issue.

Would you consider this behaviour a bug? It certainly seems like one if you can add a library and have compilation fail in an non-obvious way.

[alexvanyo]

ui-test:1.7.x does have a strict dependency on at least ui:1.6.x, but that transitive update to ui is being ignored in favor of the dependency from main configuration, since we are only declaring the ui-test dependency in test.

This has come up before such as in android/android-test#1315 (comment)

This definitely feels buggy - it's not clear at all why the version is "fixed" to the one in the main source set instead of being bumped by the one in the test source set.

We should follow-up with AGP folks to use this as an example of whether this behavior can be improved.

[sanao1006]

Hi @dturner

Hi @sanao1006, many thanks for submitting this PR. Unfortunately I already had a branch with this change in it ready to go (plus some slight cosmetic differences e.g. version catalog naming) so I will merge this PR instead when we're ready.

I understand. Thanks for contacting me!

It is OK to close this PR when your discussion is complete!

[alexvanyo]

Closing this PR - #1140 has more info about the resolution restrictions as reference.