Replace Accompanist TestHarness with DeviceConfigurationOverride #1230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
dturner
commented
Feb 26, 2024
.../testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
Show resolved
Hide resolved
Change-Id: Ib1bbe4ad0d823c632d387587aa55c5eeb39e4b8d
Change-Id: Ibf93c1b65250e6527e34bc90602c1b1001b2df46
alexvanyo
approved these changes
Feb 27, 2024
.../testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
Outdated
Show resolved
Hide resolved
…i/NiaAppScreenSizesScreenshotTests.kt Co-authored-by: Alex Vanyo <vanyo@google.com>
dturner
force-pushed
the
replace-testharness
branch
from
77ef6e7 to
6810e48
Compare
* main: (37 commits) Disable animations of instrumented tests (#1167) Bump gradle/wrapper-validation-action from 1 to 2 Remove unused release variable. Fixes #1231 Apply Composable Parameter Ordering Guidelines Remove kotlinx-coroutines-guava dependency from :sync:work Add explicit guava-android dependency for :sync:work Extract ScreenshotHelper to separate testing module Update AGP to 8.3.0 Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert. 🤖 Updates baselines for Dependency Guard Bump the kotlin-ksp-compose group with 6 updates 🤖 Updates baselines for Dependency Guard Bump hilt from 2.50 to 2.51 Bump com.google.truth:truth from 1.1.5 to 1.4.2 Move java to kotlin folder. Remove disk usage testing Figuring out what is using 66Gb in the runner Dpm Improve converting to kotlin timezone Use trySend multiple times ... Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
dturner
force-pushed
the
replace-testharness
branch
from
6810e48 to
2d610b0
Compare
alexvanyo
reviewed
Mar 6, 2024
.../testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
Outdated
Show resolved
Hide resolved
Change-Id: I335f9f5da1ff3f2574acca8e3fcb27b949a07c7a
Change-Id: I98a9b9fa1de5cc0bb3a3caa7d795053fd784b238
alexvanyo
approved these changes
Mar 28, 2024
|
Instrumented tests fail when I check out the code and run them locally. Is there a way to kick Github Actions? "Show all checks" is only showing the |
|
@jdkoren this is because of this issue: If you want to check previous builds, you can click the ❌ next to the commit id in this page. |
|
Instrumented tests are failing with: Root cause: Updating to |
Change-Id: I05eb2993c41574a1ec9973e8dca3290d31ffc21f
Change-Id: Ie49b67981929fd3932ce3da68571a6305cf67aef
Combined test coverage report
Files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compose UI 1.7.0-alpha02 added the DeviceConfigurationOverride API which replaces the Accompanist TestHarness API.
This mostly involves changing
to
Full migration guide here.
I have:
TestHarnesswithDeviceConfigurationOverrideFixes #1201