Skip to content

Commit

Permalink
fix(android): correct lint issues for various API mis-use
Browse files Browse the repository at this point in the history
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes invertase#3917)
  • Loading branch information
mikehardy committed May 18, 2021
1 parent 50c9e22 commit 028ba89
Showing 1 changed file with 2 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;
import java.util.Locale;
import java.util.Map;
import java.util.Objects;
import java.util.concurrent.TimeUnit;
Expand Down Expand Up @@ -1885,7 +1886,7 @@ private WritableMap getJSError(Exception exception) {
}

code = code
.toLowerCase()
.toLowerCase(Locale.ROOT)
.replace("error_", "")
.replace('_', '-');
error.putString("code", code);
Expand Down

0 comments on commit 028ba89

Please sign in to comment.