Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 Auth error uses the character 'ı' instead of 'i' #3917

Closed
2 of 7 tasks
yunusemregul opened this issue Jul 9, 2020 · 15 comments · Fixed by #5335
Closed
2 of 7 tasks

🔥 Auth error uses the character 'ı' instead of 'i' #3917

yunusemregul opened this issue Jul 9, 2020 · 15 comments · Fixed by #5335
Labels
blocked: firebase-sdk Pending a confirmed fix landing on the official native sdk's (iOS/Android). plugin: authentication Firebase Authentication

Comments

@yunusemregul
Copy link

yunusemregul commented Jul 9, 2020

Issue

Auth error has 'ı' s instead of 'i' s.

Heres the output for below code:
image
image


Project Files

iOS

Click To Expand

ios/Podfile:

  • I'm not using Pods
  • I'm using Pods and my Podfile looks like:
# N/A

AppDelegate.m:

// N/A


Android

Click To Expand

android/build.gradle:

// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext {
        buildToolsVersion = "28.0.3"
        minSdkVersion = 21
        compileSdkVersion = 28
        targetSdkVersion = 28
    }
    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath("com.android.tools.build:gradle:3.5.3")

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files

        classpath 'com.google.gms:google-services:4.2.0'
    }
}

allprojects {
    repositories {
        mavenLocal()
        maven {
            // All of React Native (JS, Obj-C sources, Android binaries) is installed from npm
            url("$rootDir/../node_modules/react-native/android")
        }
        maven {
            // Android JSC is installed from npm
            url("$rootDir/../node_modules/jsc-android/dist")
        }

        google()
        jcenter()
        maven { url 'https://www.jitpack.io' }
    }
}

android/app/build.gradle:

apply plugin: "com.android.application"
apply plugin: 'com.google.gms.google-services'

import com.android.build.OutputFile

/**
 * The react.gradle file registers a task for each build variant (e.g. bundleDebugJsAndAssets
 * and bundleReleaseJsAndAssets).
 * These basically call `react-native bundle` with the correct arguments during the Android build
 * cycle. By default, bundleDebugJsAndAssets is skipped, as in debug/dev mode we prefer to load the
 * bundle directly from the development server. Below you can see all the possible configurations
 * and their defaults. If you decide to add a configuration block, make sure to add it before the
 * `apply from: "../../node_modules/react-native/react.gradle"` line.
 *
 * project.ext.react = [
 *   // the name of the generated asset file containing your JS bundle
 *   bundleAssetName: "index.android.bundle",
 *
 *   // the entry file for bundle generation. If none specified and
 *   // "index.android.js" exists, it will be used. Otherwise "index.js" is
 *   // default. Can be overridden with ENTRY_FILE environment variable.
 *   entryFile: "index.android.js",
 *
 *   // https://facebook.github.io/react-native/docs/performance#enable-the-ram-format
 *   bundleCommand: "ram-bundle",
 *
 *   // whether to bundle JS and assets in debug mode
 *   bundleInDebug: false,
 *
 *   // whether to bundle JS and assets in release mode
 *   bundleInRelease: true,
 *
 *   // whether to bundle JS and assets in another build variant (if configured).
 *   // See http://tools.android.com/tech-docs/new-build-system/user-guide#TOC-Build-Variants
 *   // The configuration property can be in the following formats
 *   //         'bundleIn${productFlavor}${buildType}'
 *   //         'bundleIn${buildType}'
 *   // bundleInFreeDebug: true,
 *   // bundleInPaidRelease: true,
 *   // bundleInBeta: true,
 *
 *   // whether to disable dev mode in custom build variants (by default only disabled in release)
 *   // for example: to disable dev mode in the staging build type (if configured)
 *   devDisabledInStaging: true,
 *   // The configuration property can be in the following formats
 *   //         'devDisabledIn${productFlavor}${buildType}'
 *   //         'devDisabledIn${buildType}'
 *
 *   // the root of your project, i.e. where "package.json" lives
 *   root: "../../",
 *
 *   // where to put the JS bundle asset in debug mode
 *   jsBundleDirDebug: "$buildDir/intermediates/assets/debug",
 *
 *   // where to put the JS bundle asset in release mode
 *   jsBundleDirRelease: "$buildDir/intermediates/assets/release",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in debug mode
 *   resourcesDirDebug: "$buildDir/intermediates/res/merged/debug",
 *
 *   // where to put drawable resources / React Native assets, e.g. the ones you use via
 *   // require('./image.png')), in release mode
 *   resourcesDirRelease: "$buildDir/intermediates/res/merged/release",
 *
 *   // by default the gradle tasks are skipped if none of the JS files or assets change; this means
 *   // that we don't look at files in android/ or ios/ to determine whether the tasks are up to
 *   // date; if you have any other folders that you want to ignore for performance reasons (gradle
 *   // indexes the entire tree), add them here. Alternatively, if you have JS files in android/
 *   // for example, you might want to remove it from here.
 *   inputExcludes: ["android/**", "ios/**"],
 *
 *   // override which node gets called and with what additional arguments
 *   nodeExecutableAndArgs: ["node"],
 *
 *   // supply additional arguments to the packager
 *   extraPackagerArgs: []
 * ]
 */

project.ext.react = [
    enableHermes: false
]


apply from: "../../node_modules/react-native/react.gradle"

/**
 * Set this to true to create two separate APKs instead of one:
 *   - An APK that only works on ARM devices
 *   - An APK that only works on x86 devices
 * The advantage is the size of the APK is reduced by about 4MB.
 * Upload all the APKs to the Play Store and people will download
 * the correct one based on the CPU architecture of their device.
 */
def enableSeparateBuildPerCPUArchitecture = false

/**
 * Run Proguard to shrink the Java bytecode in release builds.
 */
def enableProguardInReleaseBuilds = false

/**
 * The preferred build flavor of JavaScriptCore.
 *
 * For example, to use the international variant, you can use:
 * `def jscFlavor = 'org.webkit:android-jsc-intl:+'`
 *
 * The international variant includes ICU i18n library and necessary data
 * allowing to use e.g. `Date.toLocaleString` and `String.localeCompare` that
 * give correct results when using with locales other than en-US.  Note that
 * this variant is about 6MiB larger per architecture than default.
 */
def jscFlavor = 'org.webkit:android-jsc:+'

/**
 * Whether to enable the Hermes VM.
 *
 * This should be set on project.ext.react and mirrored here.  If it is not set
 * on project.ext.react, JavaScript will not be compiled to Hermes Bytecode
 * and the benefits of using Hermes will therefore be sharply reduced.
 */
def enableHermes = project.ext.react.get("enableHermes", false);

android {
    compileSdkVersion rootProject.ext.compileSdkVersion

    compileOptions {
        sourceCompatibility JavaVersion.VERSION_1_8
        targetCompatibility JavaVersion.VERSION_1_8
    }

    defaultConfig {
        applicationId 'com.imgpaylas'
        minSdkVersion rootProject.ext.minSdkVersion
        targetSdkVersion rootProject.ext.targetSdkVersion
        versionCode 1
        versionName "1.0.0"
    }
    splits {
        abi {
            reset()
            enable enableSeparateBuildPerCPUArchitecture
            universalApk false  // If true, also generate a universal APK
            include "armeabi-v7a", "x86", "arm64-v8a", "x86_64"
        }
    }
    signingConfigs {
        debug {
            storeFile file('debug.keystore')
            storePassword 'android'
            keyAlias 'androiddebugkey'
            keyPassword 'android'
        }
        release {
            if (project.hasProperty('MYAPP_RELEASE_STORE_FILE')) {
                storeFile file(MYAPP_RELEASE_STORE_FILE)
                storePassword MYAPP_RELEASE_STORE_PASSWORD
                keyAlias MYAPP_RELEASE_KEY_ALIAS
                keyPassword MYAPP_RELEASE_KEY_PASSWORD
            }
        }
    }
    buildTypes {
        debug {
            signingConfig signingConfigs.debug
        }
        release {
            // Caution! In production, you need to generate your own keystore file.
            // see https://facebook.github.io/react-native/docs/signed-apk-android.
            signingConfig signingConfigs.release
            minifyEnabled enableProguardInReleaseBuilds
            proguardFiles getDefaultProguardFile("proguard-android.txt"), "proguard-rules.pro"
        }
    }

    packagingOptions {
        pickFirst "lib/armeabi-v7a/libc++_shared.so"
        pickFirst "lib/arm64-v8a/libc++_shared.so"
        pickFirst "lib/x86/libc++_shared.so"
        pickFirst "lib/x86_64/libc++_shared.so"
    }

    // applicationVariants are e.g. debug, release
    applicationVariants.all { variant ->
        variant.outputs.each { output ->
            // For each separate APK per architecture, set a unique version code as described here:
            // https://developer.android.com/studio/build/configure-apk-splits.html
            def versionCodes = ["armeabi-v7a": 1, "x86": 2, "arm64-v8a": 3, "x86_64": 4]
            def abi = output.getFilter(OutputFile.ABI)
            if (abi != null) {  // null for the universal-debug, universal-release variants
                output.versionCodeOverride =
                        versionCodes.get(abi) * 1048576 + defaultConfig.versionCode
            }

        }
    }
}

dependencies {
    implementation fileTree(dir: "libs", include: ["*.jar"])
    //noinspection GradleDynamicVersion
    implementation "com.facebook.react:react-native:+"  // From node_modules
    implementation "androidx.swiperefreshlayout:swiperefreshlayout:1.0.0"
    debugImplementation("com.facebook.flipper:flipper:${FLIPPER_VERSION}") {
      exclude group:'com.facebook.fbjni'
    }
    debugImplementation("com.facebook.flipper:flipper-network-plugin:${FLIPPER_VERSION}") {
        exclude group:'com.facebook.flipper'
    }
    debugImplementation("com.facebook.flipper:flipper-fresco-plugin:${FLIPPER_VERSION}") {
        exclude group:'com.facebook.flipper'
    }

    if (enableHermes) {
        def hermesPath = "../../node_modules/hermes-engine/android/";
        debugImplementation files(hermesPath + "hermes-debug.aar")
        releaseImplementation files(hermesPath + "hermes-release.aar")
    } else {
        implementation jscFlavor
    }
}

// Run this once to be able to run the application with BUCK
// puts all compile dependencies into folder libs for BUCK to use
task copyDownloadableDepsToLibs(type: Copy) {
    from configurations.compile
    into 'libs'
}

apply from: file("../../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesAppBuildGradle(project)

android/settings.gradle:

rootProject.name = 'imgpaylas'
apply from: file("../node_modules/@react-native-community/cli-platform-android/native_modules.gradle"); applyNativeModulesSettingsGradle(settings)
include ':app'

MainApplication.java:

package com.imgpaylas;

import android.app.Application;
import android.content.Context;
import com.facebook.react.PackageList;
import com.facebook.react.ReactApplication;
import com.facebook.react.ReactInstanceManager;
import com.facebook.react.ReactNativeHost;
import com.facebook.react.ReactPackage;
import com.facebook.soloader.SoLoader;
import java.lang.reflect.InvocationTargetException;
import java.util.List;

public class MainApplication extends Application implements ReactApplication {

  private final ReactNativeHost mReactNativeHost =
      new ReactNativeHost(this) {
    @Override
    public boolean getUseDeveloperSupport() {
      return BuildConfig.DEBUG;
    }

    @Override
    protected List<ReactPackage> getPackages() {
          @SuppressWarnings("UnnecessaryLocalVariable")
      List<ReactPackage> packages = new PackageList(this).getPackages();
          // Packages that cannot be autolinked yet can be added manually here, for example:
          // packages.add(new MyReactNativePackage());
      return packages;
    }

    @Override
    protected String getJSMainModuleName() {
      return "index";
    }
  };

  @Override
  public ReactNativeHost getReactNativeHost() {
    return mReactNativeHost;
  }

  @Override
  public void onCreate() {
    super.onCreate();
    SoLoader.init(this, /* native exopackage */ false);
    initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
  }

  /**
   * Loads Flipper in React Native templates. Call this in the onCreate method with something like
   * initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
   *
   * @param context
   * @param reactInstanceManager
   */
  private static void initializeFlipper(
      Context context, ReactInstanceManager reactInstanceManager) {
    if (BuildConfig.DEBUG) {
      try {
        /*
         We use reflection here to pick up the class that initializes Flipper,
        since Flipper library is not available in release mode
        */
        Class<?> aClass = Class.forName("com.imgpaylas.ReactNativeFlipper");
        aClass
            .getMethod("initializeFlipper", Context.class, ReactInstanceManager.class)
            .invoke(null, context, reactInstanceManager);
      } catch (ClassNotFoundException e) {
        e.printStackTrace();
      } catch (NoSuchMethodException e) {
        e.printStackTrace();
      } catch (IllegalAccessException e) {
        e.printStackTrace();
      } catch (InvocationTargetException e) {
        e.printStackTrace();
      }
    }
  }
}

AndroidManifest.xml:

<manifest xmlns:android="http://schemas.android.com/apk/res/android"
  package="com.imgpaylas">

    <uses-permission android:name="android.permission.INTERNET" />

    <application
      android:name=".MainApplication"
      android:label="@string/app_name"
      android:icon="@mipmap/ic_launcher"
      android:roundIcon="@mipmap/ic_launcher_round"
      android:allowBackup="false"
      android:theme="@style/AppTheme">
      <activity
        android:name=".MainActivity"
        android:label="@string/app_name"
        android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
        android:launchMode="singleTask"
        android:windowSoftInputMode="adjustResize">
      <intent-filter>
            <action android:name="android.intent.action.MAIN" />
            <category android:name="android.intent.category.LAUNCHER" />
      </intent-filter>
    </activity>
      <activity android:name="com.facebook.react.devsupport.DevSettingsActivity" />
  </application>

</manifest>


Environment

Click To Expand

react-native info output:

System:
    OS: Windows 10 10.0.18362
    CPU: (8) x64 Intel(R) Core(TM) i7-4712MQ CPU @ 2.30GHz
    Memory: 6.57 GB / 15.91 GB
  Binaries:
    Node: 12.18.2 - C:\Program Files\nodejs\node.EXE
    Yarn: Not Found
    npm: 6.14.5 - C:\Program Files\nodejs\npm.CMD
    Watchman: Not Found
  SDKs:
    Android SDK: Not Found
  IDEs:
    Android Studio: Version  4.0.0.0 AI-193.6911.18.40.6514223
  Languages:
    Java: 1.8.0_251
    Python: 2.7.9
  npmPackages:
    @react-native-community/cli: Not Found
    react: ~16.11.0 => 16.11.0
    react-native: ~0.62.2 => 0.62.2
  npmGlobalPackages:
    *react-native*: Not Found
  • Platform that you're experiencing the issue on:
    • iOS
    • Android
    • iOS but have not tested behavior on Android
    • Android but have not tested behavior on iOS
    • Both
  • Firebase module(s) you're using that has the issue:
    • Firebase Auth
  • Are you using TypeScript?
    • N


@mikehardy
Copy link
Collaborator

@yunusemregul nice catch! Can you post a PR that corrects it? The github web UI for posting small PRs is possibly even quicker than logging the issue 🙏

@yunusemregul
Copy link
Author

yunusemregul commented Jul 9, 2020

@yunusemregul nice catch! Can you post a PR that corrects it? The github web UI for posting small PRs is possibly even quicker than logging the issue

Well, I didn't expect that I would be the one to fix it. I dont think that this is a simple typo somewhere in react-native-firebase code, I believe this error has something odd with it.

I will try my best to find the cause and send a PR if I can fix it.

@mikehardy
Copy link
Collaborator

Well, open source fixes are always faster when the interested person goes ahead and posts the PR but I think you might have a bad case for it because I think auth is actually not open sourced (I can't find it here? https://github.com/firebase/firebase-android-sdk) and from what I can tell in the code here we take an auth error:

call a reject method

private void promiseRejectAuthException(Promise promise, Exception exception) {

which delegates and just uses the raw stuff from the SDK:

public static void rejectPromiseWithCodeAndMessage(Promise promise, String code, String message) {

This may need to be logged as an upstream issue in firebase-android-sdk as the best next step

@yunusemregul
Copy link
Author

yunusemregul commented Jul 10, 2020

Well, open source fixes are always faster when the interested person goes ahead and posts the PR but I think you might have a bad case for it because I think auth is actually not open sourced (I can't find it here? https://github.com/firebase/firebase-android-sdk) and from what I can tell in the code here we take an auth error:

call a reject method

private void promiseRejectAuthException(Promise promise, Exception exception) {

which delegates and just uses the raw stuff from the SDK:

public static void rejectPromiseWithCodeAndMessage(Promise promise, String code, String message) {

This may need to be logged as an upstream issue in firebase-android-sdk as the best next step

I appreciate that you sent the sources related to the issue. I checked them all and as you mentioned it, seems that the issue is not with the react-native-firebase code.

It is so odd tho. I think it could be with my android environment somehow. My local language on the android is Turkish and in Turkish these 'ı's and 'i's mix easily.

Maybe deep in firebase-sdk, it somehow localizes the error codes but it is stupid, why did they make it this way if they did. I really wonder what is the cause.

@mikehardy
Copy link
Collaborator

Hard to say - I'd definitely pursue it upstream. In my experience managing a large project with i18n and some languages that have ligatures like that, it's a massive task simply to internationalize everything, and those are the exact sorts of errors that slip through quality checks

@andersonaddo andersonaddo added plugin: authentication Firebase Authentication blocked: firebase-sdk Pending a confirmed fix landing on the official native sdk's (iOS/Android). labels Jul 10, 2020
@stale
Copy link

stale bot commented Aug 8, 2020

Hello 👋, to help manage issues we automatically close stale issues.
This issue has been automatically marked as stale because it has not had activity for quite some time. Has this issue been fixed, or does it still require the community's attention?

This issue will be closed in 15 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the Type: Stale Issue has become stale - automatically added by Stale bot label Aug 8, 2020
@stale
Copy link

stale bot commented Aug 23, 2020

Closing this issue after a prolonged period of inactivity. If this is still present in the latest release, please feel free to create a new issue with up-to-date information.

@stale stale bot closed this as completed Aug 23, 2020
@ogous
Copy link

ogous commented Apr 13, 2021

@yunusemregul @mikehardy this issue is still active on version 11.2.0. I came across it on development android emulator environment when I changed system language to Turkish. I currently don't know if it's an issue for production too, if it is, becomes much more annoying. It makes error handling unstable for different system languages. @yunusemregul did you figure out something later on? Is it reproducible on production and real devices too?

@mikehardy
Copy link
Collaborator

auth is still not open source in firebase-android-sdk - but based on the comments above it appears that opening an issue there is the next step?

@yunusemregul
Copy link
Author

@yunusemregul @mikehardy this issue is still active on version 11.2.0. I came across it on development android emulator environment when I changed system language to Turkish. I currently don't know if it's an issue for production too, if it is, becomes much more annoying. It makes error handling unstable for different system languages. @yunusemregul did you figure out something later on? Is it reproducible on production and real devices too?

I couldn't find any solution to this except catching the errors both with 'i' and 'ı' as in my issue screenshot. As @mikehardy said this problem has to be with the upstream firebase-android-sdk.

@mikehardy
Copy link
Collaborator

Well to be clear, I did the best analysis I could but I am human - I posted my references though so others can verify in case I got something wrong. By my analysis we (react-native-firebase) are just passing along underlying data from firebase-android-sdk though, which is why I assert it is a firebase-android-sdk issue

@mikehardy
Copy link
Collaborator

FWIW I had this come up in another repo and I just finally remembered it - it is an incorrect use of Locales for toLower I think - should use

https://developer.android.com/reference/java/util/Locale#ROOT

That is internal to firebase-android-sdk though

@mikehardy
Copy link
Collaborator

firebase/firebase-android-sdk#2593

@mikehardy
Copy link
Collaborator

While working on something unrelated, I think I may have seen that this was in our code. Re-opening, and a commit in a moment will close it, I would greatly appreciate if you could retest after you update to any release after v12 @yunusemregul or @oguzhanali 🙏 - it might fix it, or it might still rely on something upstream

@mikehardy mikehardy reopened this May 18, 2021
@yunusemregul yunusemregul reopened this May 18, 2021
@stale stale bot removed the Type: Stale Issue has become stale - automatically added by Stale bot label May 18, 2021
@yunusemregul
Copy link
Author

While working on something unrelated, I think I may have seen that this was in our code. Re-opening, and a commit in a moment will close it, I would greatly appreciate if you could retest after you update to any release after v12 @yunusemregul or @oguzhanali 🙏 - it might fix it, or it might still rely on something upstream

Thank you I will try to test it whenever I can.

mikehardy added a commit that referenced this issue May 18, 2021
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes #3917)
mikehardy added a commit that referenced this issue May 18, 2021
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes #3917)
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this issue Aug 9, 2021
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes invertase#3917)
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this issue Aug 9, 2021
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes invertase#3917)
androidIsForVivek pushed a commit to androidIsForVivek/react-native-firebase that referenced this issue Sep 15, 2021
Highlights:

- enforce CallSuper so TaskExecutors will always clean up correctly
- enforce Locale translation in string manipulaton (Fixes invertase#3917)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: firebase-sdk Pending a confirmed fix landing on the official native sdk's (iOS/Android). plugin: authentication Firebase Authentication
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants