SYSENG-1335: reserve available IP addresses #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
self-assigned this
ghost
force-pushed
the
SYSENG-1335/create-ip-address-in-prefix
branch
from
236394c to
d8f725c
Compare
ghost
changed the title
ghost
force-pushed
the
SYSENG-1335/create-ip-address-in-prefix
branch
from
d8f725c to
9de898c
Compare
nachtjasmin
previously approved these changes
Jun 6, 2024
ghost
force-pushed
the
SYSENG-1335/create-ip-address-in-prefix
branch
3 times, most recently
from
d3b4b61 to
8cb83f7
Compare
ghost
force-pushed
the
SYSENG-1335/create-ip-address-in-prefix
branch
from
8cb83f7 to
f53c034
Compare
ghost
marked this pull request as ready for review
nachtjasmin
requested changes
Jun 7, 2024
| @@ -152,6 +152,8 @@ func TestAccAnxCloudVirtualServer(t *testing.T) { | |||
| } | |||
|
|
|||
| func TestAccAnxCloudVirtualServerFromScratch(t *testing.T) { | |||
| t.Skip("specific from_scratch templates no longer available") | |||
There was a problem hiding this comment.
Not sure whether we should just remove the test in this case. I don't think it'll come back and even if, we can always revert the commit for that. ^^
There was a problem hiding this comment.
There is a new more generic from_scratch template which is still somewhat WIP and could cause some issues that require manual intervention. I think if we remove it entirely, it will probably be overlooked in the future.
There was a problem hiding this comment.
Hm, okay, let's keep it then! 👍
nachtjasmin
approved these changes
Jun 7, 2024
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reserve an available address based on filters.
Checklist
Unreleasedsection in CHANGELOG.md, if user facing changeReferences
Community Note