Kmeans notebook cleanup #946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # templates/example_neighborhood_analysis_script.ipynb
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cliu72
reviewed
Mar 16, 2023
|
I think it looks great! Just some minor suggestions for wording, but open to other suggestions. I think being able to read in an existing neighborhood matrix is a good idea. |
srivarra
approved these changes
Mar 21, 2023
ngreenwald
reviewed
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #876.
How did you implement your changes
Added more clear descriptions of what is actually being shown by the generated heat maps. Also fixed a few pandas warning messages that were clogging up the notebook outputs.
The visualizations were all updated as well to reflect the example dataset with a cropped fov1.
Remaining issues
If anyone has specific additions they want added into the kmeans notebook, let me know!