Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

Tooltip show wierdly even if content is whitespaces #1780

Closed
thierryx96 opened this issue Feb 11, 2014 · 6 comments · Fixed by #4455
Closed

Tooltip show wierdly even if content is whitespaces #1780

thierryx96 opened this issue Feb 11, 2014 · 6 comments · Fixed by #4455
Labels
component: tooltip type: bug

Comments

@thierryx96
Copy link

Tooltips show, even if text is white spaces. The content (whitespaces) isn't even displayed, which in my opinion is inconsistent behavior ;) . My fix proposal is checking if the text is empty (as it is already), and whitespace(s) to prevent the tooltip rendering.

tooltip_normal
tooltip_whitespaces
@pkozlowski-opensource
Copy link
Member

@thierryx96 could you please provide a minimal reproduce scenario using http://plnkr.co/? What is the version of this library you are using? You issue looks weird as there is a check on the tooltips side to check if content is not empty. I also can't reproduce this issue on our demo page.

@thierryx96
Copy link
Author

Hi Pawel,

Please find the Plunk'r there : plnkr.co/edit/Es575RLYwlz139jw2RQZ?p=preview.

Version :
-angular-ui-bootstrap : 0.9.0 (but same issue with 0.10.0)
-angular : 1.2.12
-Bootstrap : 3.0.3

Cheers,

Thierry

@pkozlowski-opensource
Copy link
Member

Thnx for the repro @thierryx96. Yup, I guess we could test for empty / blank content. For now you could write a simple trim filter to get rid of whitespaces, I guess. Will push a fix for this one in the coming days, should be pretty trivial. A PR would be welcomed.

@pkozlowski-opensource
Copy link
Member

BTW: I hope you know that you don't need to include Bootstrap's JavaScript to have those directives working properly.

@thierryx96 thierryx96 mentioned this issue Feb 11, 2014
Closed
@thierryx96
Copy link
Author

I just did the PR now. Yeah, BS JavaScript, was just fiddling with Plunk'r, thanks for the hint tho ;).

Cheers,

th

@wesleycho wesleycho reopened this Mar 16, 2015
@wesleycho
Copy link
Contributor

Re-opened, issue was never resolved.

@RobJacobs RobJacobs mentioned this issue Sep 23, 2015
Merged
jasonaden pushed a commit to deskfed/bootstrap that referenced this issue Jan 8, 2016
@RobJacobs @jasonaden
refactor(tooltip): rollup commit for several issues
b5e2124 
This is a rollup commit intended to address several
issues around the positioning and parsing of
attributes.

- Fixes issue introduced under PR angular-ui#4311 where setting
  height and width in tooltip position function
  messed up arrow placement.
- Fixes issue introduced under PR angular-ui#4363 where setting
  visibility to hidden in tooltip position function
  caused elements in popover to lose focus.
- Fixes issue angular-ui#1780 where tooltip would render if
  content was just whitespace.
- Fixes issue angular-ui#3347 where tooltip isolate scope was
  being accessed after it was set to null.  Observers
  will now be created/destroyed as tooltip opens/closes
  which will also offer a performance improvement.
- Fixes issue angular-ui#3557 by implementing evalAsync to set
  tooltip scope isOpen property.
- Fixes issue angular-ui#4335 where if model isOpen property is
  undefined, tooltip would call show/hide toggle function.
- Closes PR angular-ui#4429 where how the templated content
  was being evaluated could cause an infinite digest loop.

Closes angular-ui#4400
Closes angular-ui#4418
Closes angular-ui#4429
Closes angular-ui#4431
Closes angular-ui#4455

Fixes angular-ui#1780
Fixes angular-ui#3347
Fixes angular-ui#3557
Fixes angular-ui#4321
Fixes angular-ui#4335
jasonaden pushed a commit to deskfed/bootstrap that referenced this issue Jan 8, 2016
@RobJacobs @jasonaden
refactor(tooltip): rollup commit for several issues
637721b 
This is a rollup commit intended to address several
issues around the positioning and parsing of
attributes.

- Fixes issue introduced under PR angular-ui#4311 where setting
  height and width in tooltip position function
  messed up arrow placement.
- Fixes issue introduced under PR angular-ui#4363 where setting
  visibility to hidden in tooltip position function
  caused elements in popover to lose focus.
- Fixes issue angular-ui#1780 where tooltip would render if
  content was just whitespace.
- Fixes issue angular-ui#3347 where tooltip isolate scope was
  being accessed after it was set to null.  Observers
  will now be created/destroyed as tooltip opens/closes
  which will also offer a performance improvement.
- Fixes issue angular-ui#3557 by implementing evalAsync to set
  tooltip scope isOpen property.
- Fixes issue angular-ui#4335 where if model isOpen property is
  undefined, tooltip would call show/hide toggle function.
- Closes PR angular-ui#4429 where how the templated content
  was being evaluated could cause an infinite digest loop.

Closes angular-ui#4400
Closes angular-ui#4418
Closes angular-ui#4429
Closes angular-ui#4431
Closes angular-ui#4455

Fixes angular-ui#1780
Fixes angular-ui#3347
Fixes angular-ui#3557
Fixes angular-ui#4321
Fixes angular-ui#4335
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
component: tooltip type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(tooltip): rollup commit for several issues
3 participants
@pkozlowski-opensource @wesleycho @thierryx96