This repository has been archived by the owner on May 29, 2019. It is now read-only.
fix(tooltip) : issue #1780, prevent rendering if text is whitespaces #1784
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tooltip : issue #1780, prevent rendering if text is whitespace
|
I am not so sure of what should be the correct behavior with empty or (whitespace) tooltip. Maybe not showing it is not the solution (an user can think that the tooltip is broken when is not) but I guess that is still better than #1780. @angular-ui/bootstrap WDYT? |
|
I don't think this is so trivial, if in the future we are going to support html as content, and also I don't believe this is a tooltip's responsibility. |
|
Closing this as outdated, feel free to open a new PR based off of current master. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tooltip : issue #1780, prevent rendering if text is whitespace.
Tooltips show, even if text is white spaces. The content (whitespaces) isn't even displayed, which in my opinion is inconsistent behavior ;) . My fix proposal is checking if the text is empty (as it is already), and whitespace(s) to prevent the tooltip rendering.
Cure : test for empty / blank content.