You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 29, 2019. It is now read-only.
PR #3126 introduced the ability to support defining a class for the tooltip as an attribute. This is causing issues with how the popover adds the placement and animation classes, this plunker demonstrates the issue. You will notice the popover does not display the arrow correctly and the animation doesn't run when it opens and closes. I've narrowed down the problem to the following line in the tooltip provider where the template variable is declared:
'class="'+startSym+'class'+endSym+'" '+
The classes on the outer popover div are not getting added correctly. The outer popover div should have:
class="popover right fade in"
but instead have:
class="popover popover in"
We should also reconsider using 'class' as a variable as that is a reserved word in ECMA 6.
The text was updated successfully, but these errors were encountered:
- Animations didn't work because the class attribute was mangled during
compilation due to the way class attributes are merged on directives with
`replace: true`
- Rename attribute to popup-class
- Refactor to rename variables named "class" as it's a keyword
and also looks weird in editors
Fixesangular-ui#3375Fixesangular-ui#3506
PR #3126 introduced the ability to support defining a class for the tooltip as an attribute. This is causing issues with how the popover adds the placement and animation classes, this plunker demonstrates the issue. You will notice the popover does not display the arrow correctly and the animation doesn't run when it opens and closes. I've narrowed down the problem to the following line in the tooltip provider where the template variable is declared:
The classes on the outer popover div are not getting added correctly. The outer popover div should have:
but instead have:
We should also reconsider using 'class' as a variable as that is a reserved word in ECMA 6.
The text was updated successfully, but these errors were encountered: