Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

tooltip - Issues with PR #3126 #3506

Closed
RobJacobs opened this issue Apr 7, 2015 · 1 comment
Closed

tooltip - Issues with PR #3126 #3506

RobJacobs opened this issue Apr 7, 2015 · 1 comment

Comments

@RobJacobs
Copy link
Contributor

PR #3126 introduced the ability to support defining a class for the tooltip as an attribute. This is causing issues with how the popover adds the placement and animation classes, this plunker demonstrates the issue. You will notice the popover does not display the arrow correctly and the animation doesn't run when it opens and closes. I've narrowed down the problem to the following line in the tooltip provider where the template variable is declared:

'class="'+startSym+'class'+endSym+'" '+

The classes on the outer popover div are not getting added correctly. The outer popover div should have:

class="popover right fade in"

but instead have:

class="popover popover in"

We should also reconsider using 'class' as a variable as that is a reserved word in ECMA 6.

@RobJacobs RobJacobs added this to the 0.13.0 milestone Apr 7, 2015
@chrisirhc chrisirhc self-assigned this Apr 7, 2015
@chrisirhc
Copy link
Contributor

Thanks! Looks like my fix (461087b) was incomplete. I'll look into this very soon.

chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 8, 2015
- Animations didn't work because the class attribute was mangled during
  compilation due to the way class attributes are merged on directives with
  `replace: true`

- Rename attribute to popup-class

- Refactor to rename variables named "class" as it's a keyword
  and also looks weird in editors

Fixes angular-ui#3375
Fixes angular-ui#3506
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants