Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

ngAnimate breaks fade-in animation of popover #3375

Closed
zdila opened this issue Mar 11, 2015 · 9 comments
Closed

ngAnimate breaks fade-in animation of popover #3375

zdila opened this issue Mar 11, 2015 · 9 comments
Assignees
@chrisirhc
Labels
component: popover type: ngAnimate
Milestone
0.13.0 (AngularJS...

Comments

@zdila
Copy link

zdila commented Mar 11, 2015

After including ngAnimate module to my application it breaks fade-in animation of popover.

Demo: http://plnkr.co/edit/3ECNoqBqfUcbwTq3MnVa
@karianna
Copy link
Contributor

versions of angular ui / bootstrap?

@zdila
Copy link
Author

zdila commented Mar 11, 2015

From the linked plunk:
angularjs/1.3.9/angular.js
angularjs/1.3.9/angular-animate.js
ui-bootstrap-tpls-0.12.1.js
bootstrap/3.3.2/css/bootstrap.min.css

@wesleycho
Copy link
Contributor

To clarify, it looks like it is breaking when the popover is entering - is this accurate?

@wesleycho wesleycho mentioned this issue Mar 16, 2015
Closed
@zdila
Copy link
Author

zdila commented Mar 16, 2015

@wesleycho, exactly.

@wesleycho
Copy link
Contributor

Can you try based on current master? The popover now supports ngAnimate

@wesleycho wesleycho added this to the 0.13.0 milestone Mar 25, 2015
@wesleycho
Copy link
Contributor

Closing, as the popover was refactored to support ngAnimate.

Let us know if this is still an issue.

@zdila
Copy link
Author

zdila commented Apr 1, 2015

Unfortunately it is still broken. Using ui-bootstrap-tpls-0.13.0-SNAPSHOT.min.js from today's clone. You can check it out at http://plnkr.co/edit/94yNAYcGjWcndpIH9AbL (ui-bootstrap-tpls-0.13.0-SNAPSHOT.js is there loaded from google drive).

@karianna karianna reopened this Apr 1, 2015
@chrisirhc chrisirhc self-assigned this Apr 2, 2015
This was referenced Apr 2, 2015
Closed
Closed
@wesleycho
Copy link
Contributor

Posting more useful Plunker for reference

@chrisirhc
Copy link
Contributor

Reopening as this isn't fixed on master at the moment. Ref: #3506

@chrisirhc chrisirhc reopened this Apr 7, 2015
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 8, 2015
@chrisirhc
fix(popover): animations with ngAnimate
9573c67 
- Animations didn't work because the class attribute was mangled during
  compilation due to the way class attributes are merged on directives with
  `replace: true`

- Rename attribute to popup-class

- Refactor to rename variables named "class" as it's a keyword
  and also looks weird in editors

Fixes angular-ui#3375
chrisirhc added a commit to chrisirhc/angular-ui-bootstrap that referenced this issue Apr 8, 2015
@chrisirhc
fix(popover): animations with ngAnimate
ed0416e 
- Animations didn't work because the class attribute was mangled during
  compilation due to the way class attributes are merged on directives with
  `replace: true`

- Rename attribute to popup-class

- Refactor to rename variables named "class" as it's a keyword
  and also looks weird in editors

Fixes angular-ui#3375
Fixes angular-ui#3506
@chrisirhc chrisirhc mentioned this issue Apr 8, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrisirhc chrisirhc

Labels
component: popover type: ngAnimate
Projects
None yet
Milestone
0.13.0 (AngularJS 1.3)
4 participants
@chrisirhc @karianna @zdila @wesleycho