Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(tooltip): Fix animation when ngAnimate is present #3391

Closed
wants to merge 1 commit into from

Conversation

wesleycho
Copy link
Contributor

  • This disables ngAnimate's animation on the tooltip element due to $animate interfering with Bootstrap's transitions

Plunker of fix in action here

This addresses #3375.

@chrisirhc
Copy link
Contributor

Instead of disabling the animation on the tooltip completely, we can use the .css approach in #2699 , with carousel.css setting up transition values of 0. That's another approach that allows users use other animations if they want.

Note that we need to upgrade the rest of angular test libs to the same version otherwise we might encounter weirdness in the tests in the future

@chrisirhc
Copy link
Contributor

Also, we're using lowercase for module names: fix(tooltip) . That's just for grunt-conventional-changelog to pick things up correctly.

@wesleycho
Copy link
Contributor Author

Ahh, I was not aware of that work - that would be a lot nicer. I had meant for this to be a stop gap solution that at least fixes the breaking problem until we got to making it truly ngAnimate compatible.

I'll review #2699 when I get home.

- This disables ngAnimate's animation on the tooltip element due to $animate interfering with Bootstrap's transitions
@wesleycho wesleycho force-pushed the fix/popup-animation branch from e063507 to 628bf0f Compare March 17, 2015 03:21
@wesleycho wesleycho changed the title fix(Tooltip): Fix animation when ngAnimate is present fix(tooltip): Fix animation when ngAnimate is present Mar 17, 2015
@wesleycho wesleycho modified the milestones: Purgatory, 0.13.x Mar 17, 2015
@wesleycho
Copy link
Contributor Author

Closing this, will revisit with a more ngAnimate compatible approach.

@wesleycho wesleycho closed this Mar 17, 2015
@wesleycho wesleycho deleted the fix/popup-animation branch March 17, 2015 06:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants