Skip to content
This repository has been archived by the owner on May 29, 2019. It is now read-only.

fix(popover): make it work with ngAnimate #3482

Closed

Conversation

chrisirhc
Copy link
Contributor

Fixes #3375

@chrisirhc chrisirhc added this to the 0.13.0 milestone Apr 2, 2015
@wesleycho
Copy link
Contributor

The previous value in the template was a binding - is this change ok as an immediately run class add?

Does this work when the user does not use ngAnimate?

@chrisirhc
Copy link
Contributor Author

Yep it works, it needs to be added immediately because otherwise ngAnimate attempts to animate the animation class (fade) along with the in class at the same time.

This PR ensures that the fade class is already there when the in class is added.

@chrisirhc
Copy link
Contributor Author

Actually, good question, on further thought, I'll detect that if ngAnimate doesn't exist, skip adding the animation classes.
Edit: I'll work on that in another PR as the tooltip requires some more changes for full ngAnimate support.

@wesleycho
Copy link
Contributor

This good for merging then?

@chrisirhc
Copy link
Contributor Author

Yep it is. Does fix the popover issues.

On Mon, Apr 6, 2015, 06:13 Wesley Cho notifications@github.com wrote:

This good for merging then?


Reply to this email directly or view it on GitHub
#3482 (comment).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngAnimate breaks fade-in animation of popover
3 participants