add --inline-client command option

[elclanrs]

This is a fix for issue #3361. This PR adds a new --inline-client option to customize Webpack's inline client URL that makes live reloading work. This is useful when your are using Vagrant or Docker and the client and host names and/or ports may differ. For example, inside Vagrant I may run ng serve on the default 4200 port and reverse proxy to port 80 which I expose in my host as port 1234. But angular-cli prints the wrong URL:

http://localhost:4200/sockjs-node/info?t=1480728685812

Producing this error:

[WDS] Disconnected!
GET http://localhost:4200/sockjs-node/info?t=1480728685812 net::ERR_CONNECTION_REFUSED

With this new option I can change it:

$ ng serve --inline-client http://localhost:1234

The above will use the right URL:

http://localhost:1234/sockjs-node/info?t=1480728685812

[hansl]

Add proper description on what it does please.

[elclanrs]

I added a description, any suggestions?

[aegyed91]

Websocket client URL for Webpack inline mode (Defaults to "http://host:port") sounds reasonable

[hansl]

Also please rebase your code with the latest master.

[aegyed91]

@elclanrs thx, this fixed my issue now i can do ng serve --inline-client https://projname.tsm.dev

this should be merged asap, until then i use npm link and keep merging in the latest master

[aegyed91]

@hansl Hi, is there any reason why this hasnt been merged?

I would happily rebase it with the latest master and resolve the conflict -the run method has been separated to serve.run.ts-, if you say u can merge it. If you can't merge it, can you please tell why?

[hansl]

Looks good, just need to rebase.

[filipesilva]

@hansl as per #3873 (comment), #3952 appears to supersede this PR in a more elegant way, by fixing options that we already have but are not working currently.

[filipesilva]

Closed in favor of #3952

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}