feat(generate): add ability to specify module for import #3811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Brocco
force-pushed
the
gen-module-select
branch
11 times, most recently
from
81fce00
to
a76fa63
Compare
filipesilva
approved these changes
Jan 2, 2017
| /import { TestComponentComponent } from '.\/test-component\/test-component.component'/)) | ||
|
|
||
| // Try to run the unit tests. | ||
| .then(() => ng('test', '--single-run')); |
There was a problem hiding this comment.
This won't actually test if the import was correctly added, since we have no tests for app.module.ts and it's not included in the test.ts compilation. You can do ng build instead though, that'll compile it and thus verify the import.
There was a problem hiding this comment.
Good call, fixed this for components, directives, pipes & services
Brocco
force-pushed
the
gen-module-select
branch
from
a76fa63
to
7f369c9
Compare
MRHarrison
pushed a commit
to MRHarrison/angular-cli
that referenced
this pull request
Feb 9, 2017
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3806