This repository has been archived by the owner on Feb 26, 2024. It is now read-only.
fix(index-async.html): update depdendencies #90
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karma conf is now exported functions how embarrassing - now it really should work need ng-scenario for e2e tests need karma-junit-reporter trying without jasmine trying some other plugins adding jasmine in I will stab someone ng-scenario is probably needed trying adding karma-ng-scenario need a package.json to specify dev deps normalise quotes
The latest version of karma relies on frameworks. In particular the ng-scenario framework, which already contains this file.
added phonecat specific info into the README.md file
- Added a json file with a list of all phones. This file fakes a backend which would typically render this list dynamically from a database.
- Added one json file with detailed information about each phone listed in phones.json
- Added images for each phone listed in phones.json
- Initial [angular-seed] project layout without default app and test code
These files are available in the app/lib folder, so we can just use those instead. This also makes it easier to keep all the file versions in sync.
- add ngApp directive to bootstrap the app - add simple template with an expression
- Added static html list with two phones into index.html
- Converted the static html list into dynamic one by:
- creating PhoneListCtrl controller for the application
- extracting the data from HTML into a the controller as an in-memory
dataset
- converting the static document into a template with the use of
`[ngRepeat]` [directive] which iterates over the dataset with phones,
clones the ngRepeat template for each instance and renders it into the
view
- Added a simple unit test to show off how to write tests and run them
with JsTD (see README.md for instructions)
- Added a search box to demonstrate how: - the data-binding works on input fields - to use [filter] filter - [ngRepeat] automatically shrinks and grows the number of phones in the view - Added an end-to-end test to: - show how end-to-end tests are written and used - to prove that the search box and the repeater are correctly wired together
- Add "age" property to the phone model - Add select box to control phone list order - Override the default order value in controller - Add unit and e2e test for this feature
- Replaced the in-memory dataset with data loaded from the server (in the form of static phone.json file to make this tutorial backend agnostic) - The json file is loaded using the [$http] service - Demonstrate the use of [services][service] and [dependency injection][DI] - The [$http] is injected into the controller through [dependency injection][DI]
- adding phone image and links to phone pages - add end2end test that verifies our phone links - css to style the page just a notch
- Introduce the [$route] service which allows binding URLs for deep-linking with
views
- Create PhoneCatCtrl which governs the entire app and contains $route
configuration
- Load the ngRoute module
- Map `/phones' to PhoneListCtrl and partails/phones-list.html
- Map `/phones/<phone-id>' to PhoneDetailCtrl and partails/phones-detail.html
- Copy deep linking parameters to root controller `params` property for access
in sub controllers
- Replace content of index.html with [ngView] directive
- Create phone list route
- Preserve existing PhoneListCtrl controller
- Move existing html from index.html to partials/phone-list.html
- Create phone details route
- Empty placeholder PhoneDetailsCtrl controller
- Empty placeholder partials/phane-details.html template
- Fetch data for and render phone detail view
- PhoneDetailCtrl controller to fetch details json with [$xhr] for a specific
phone
- template for the phone detailed view
- CSS to make the phone details page look "pretty"
- Added custom checkmark filter - Update phone detail template to use checkmark filter - Added spec for the filter
In the phone detail view, clicking on a thumbnail image, changes the main phone image to be the large version of the thumbnail image. - Define mainImageUrl model variable in the PhoneDetailCtrl and set its default value - Create setImage controller method to change mainImageUrl - Register ng:click handler for thumb images to use setImage controller method - Add e2e tests for this feature - Add css to change the mouse cursor when user points at thumnail images
- Replaced [$xhr] with [$resource] - Created a custom Phone service that represents the $resource client
| ], function() { | ||
| // when all is done, execute bootstrap angular application | ||
| angular.bootstrap(document, ['myApp']); | ||
| }); | ||
| debugger; |
There was a problem hiding this comment.
Doh! Remove this!
|
This is now dealt with automatically by the release script. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary PR to hold the changes that will be needed when angular/angular.js#4874 lands.
Fixes #32