refactor($animate): use single variables for handling transition/animati...

[mgol]

...on events & properties

To avoid code duplication, use single variables for keeping properties/events
names to use. Also, fix some errors that have happened after the rewrite from moment ago.

[mary-poppins]

Thanks for the PR!

• Contributor signed CLA now or in the past
  • If you just signed, leave a comment here with your real name
• PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

[mgol]

The bot @mary-poppins lies, I've signed the CLA long ago and got even a couple of pull requests merged...

[mgol]

I've also changed order of rules applied in tests - it's important that unprefixed rules are at the end, before vendor prefixed ones in case there are any implementation differences between these two and a browser implements both (and yes, it has happened in the past, e.g. with linear-gradient).

[mgol]

I separated the $animate simplification and correcting tests to separate commits for clarity.

[mgol]

This should be ready for merging. :) cc @matsko @mhevery.

[mgol]

Just wanted to point out this Travis failure is not my fault. ;) A browser got disconnected

[matsko]

@mzgol wonderful work!

[mgol]

Thanks, @matsko :)

[matsko]

The changes look great. I'm just waiting on one final commit to be placed in and I'll rebase your code again and push the update: #4171

[matsko]

Here's the final rebased branch: https://github.com/matsko/angular.js/commits/pr_3908

I added an extra comment and fixed the merge commits so it works on master.

Just waiting for the CI server to finish testing it. Let me know if there is any issue before I merge it to master. Any last changes or things you see that should be fixed?

[matsko]

OK @mzgol waiting on your final say, the PR is up to date and bug free :) https://github.com/matsko/angular.js/commits/pr_3908

[mgol]

@matsko I've just looked into it and it looks ok. So if tests are passing, 👍 from me. :)

[matsko]

MERGED

[matsko]

Landed as f316c31 and ac2d06b

[matsko]

Thanks @mzgol for putting this together.

[mgol]

Thanks for merging! :)