Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngAnimate): ensure that delays are always considered before an animation closes #4150

Closed
wants to merge 2 commits into from

Conversation

matsko
Copy link
Contributor

@matsko matsko commented Sep 25, 2013

Closes #4028

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@mgol
Copy link
Member

mgol commented Sep 25, 2013

@matsko This is going to conflict with #3908... :( Could you merge it? Rebasing such things is tedious.

@matsko
Copy link
Contributor Author

matsko commented Sep 26, 2013

@mzgol going to have this merged in first and then I'll do the rebase on your code.

@mgol
Copy link
Member

mgol commented Sep 26, 2013

@matsko Thanks! :)

@matsko
Copy link
Contributor Author

matsko commented Sep 26, 2013

MERGED

Landed as 0a63adc

@matsko matsko closed this Sep 26, 2013
@mgol
Copy link
Member

mgol commented Sep 26, 2013

@matsko Oh, so you didn't rebase on my PR after all. Any reason why?

@matsko
Copy link
Contributor Author

matsko commented Sep 26, 2013

Getting to it :) Will be rebased soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ngAnimate - Incorrect detection of transition end (too early / never)
4 participants