This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile): Major Memory Leak in Directive '&' attribute #6807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For functions that have a '&' binding on the scope, change the function from an inline definition to an external definition so the function closure has no access to the parent scope. Backport of fix on 1.3.x Closes angular#6794
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
btesser
changed the title
For functions that have a '&' binding on the scope, change the function from an inline definition to an external definition so the function closure has no access to the parent scope. Backport of fix on 1.3.x Closes angular#6794
…1.2.x Conflicts: src/ng/compile.js
btesser
changed the title
|
It closes also #6801 which fixes exacty the same problem, but this one with comments looks a bit nicer |
|
@btesser Sorry, didn't notice that |
|
as discussed with @lgalfaso today there is no evidence that this patch actually does anything. applying it or not, the leak is still present. the leak that we can reproduce is present even when & bindings are not being used. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: bug
How to reproduce: http://plnkr.co/edit/TW2TjC8JkxlDyQRCLcRg
Start on Home, click link for Leak directive, click link for Home page.
In chrome timeline force garbage collection.
Take heap snapshot. Despite being entirely gone from the page and no external references, directive is not GC'ed and because it contains a reference to it's parent, the parent is not collected either.
Component(s): $compile
Impact: large
Complexity: small
This issue is related to: a memory leak
Detailed Description:
When a directive is written using '&' reverse one way binding there is a major memory leak.
when & attribute removed, leak is gone.
Other Comments:
For functions that have a '&' binding on the scope, change the function
from an inline definition to an external definition so the function
closure has no access to the parent scope.
Backport of fix on 1.3.x
Closes #6794