-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mat-slide-toggle using incorrect text color in dark-theme #18701
Labels
area: material/slide-toggle
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Comments
crisbeto
added
has pr
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
labels
Mar 6, 2020
crisbeto
added a commit
to crisbeto/material2
that referenced
this issue
Mar 6, 2020
… with a dark theme The slide toggle doesn't define its text color, but inherits it from the closest theme root element. The problem is that if the element is moved out to something like an overlay, the color may be inherited from the `body` which won't be correct. These changes explicitly set the `color`. Fixes angular#18701.
mmalerba
pushed a commit
that referenced
this issue
Apr 7, 2020
… with a dark theme The slide toggle doesn't define its text color, but inherits it from the closest theme root element. The problem is that if the element is moved out to something like an overlay, the color may be inherited from the `body` which won't be correct. These changes explicitly set the `color`. Fixes #18701.
When I tested this using the MDC based slide-toggle and menu components which are coming soon in v15, the text color is correct |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: material/slide-toggle
P3
An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Reproduction
Steps to reproduce:
Expected Behavior
What behavior were you expecting to see?
Expect mat-slide-toggle text to be white in dark-theme
Actual Behavior
What behavior did you actually see?
mat-slide-toggle text is black in dark-theme
Environment
The text was updated successfully, but these errors were encountered: