fix(slide-toggle): incorrect text color when placed inside an overlay with a dark theme #18742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with a dark theme The slide toggle doesn't define its text color, but inherits it from the closest theme root element. The problem is that if the element is moved out to something like an overlay, the color may be inherited from the `body` which won't be correct. These changes explicitly set the `color`. Fixes angular#18701.
crisbeto
added
P3
googlebot
added
the
cla: yes
devversion
approved these changes
Mar 6, 2020
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 12, 2020
…h a dark theme This is along the same lines as angular#18742. The checkbox inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Apr 19, 2020
… dark theme Fixes a similar issue to angular#18742. The radio button inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.
|
@crisbeto ~51 screenshot targets failing on this one. Change seems like an improvement, but probably not worth the effort to approve all the diffs since MDC (probably?) fixes this also. |
jelbourn
added
the
presubmit failures
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 9, 2021
…ay with a dark theme Fixes a similar issue to angular#18742. The radio button inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jun 9, 2021
…erlay with a dark theme This is along the same lines as angular#18742. The checkbox inherits its text color from the closest parent which may not be correct once the element is moved out into an overlay.
andrewseguin
removed
the
cla: yes
andrewseguin
removed
the
action: merge
|
Needs to be rebased and updated to the new theming API - you might want to just close this PR since it'll soon be deprecated and it sounds like theres a fair amount of screenshot issues on it |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The slide toggle doesn't define its text color, but inherits it from the closest theme root element. The problem is that if the element is moved out to something like an overlay, the color may be inherited from the
bodywhich won't be correct. These changes explicitly set thecolor.Fixes #18701.