Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename PortalHost to PortalOutlet #7544

Closed
jelbourn opened this issue Oct 5, 2017 · 1 comment · Fixed by #7546
Closed

Rename PortalHost to PortalOutlet #7544

jelbourn opened this issue Oct 5, 2017 · 1 comment · Fixed by #7546
Assignees
@crisbeto
Labels
P2 The issue is important to a large percentage of users, with a workaround

Comments

@jelbourn
Copy link
Member

jelbourn commented Oct 5, 2017

This will make it more consistent with RouterOutler, NgTemplateOutlet, NgComponentOutlet, etc.

We should still export the old name as deprecated.
@jelbourn jelbourn added the P2 The issue is important to a large percentage of users, with a workaround label Oct 5, 2017
@crisbeto crisbeto self-assigned this Oct 5, 2017
@crisbeto crisbeto added the has pr label Oct 5, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 5, 2017
@crisbeto
refactor(portal): rename PortalHost to PortalOutlet
424a569 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes angular#7544.
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 5, 2017
@crisbeto
refactor(portal): rename PortalHost to PortalOutlet
d4cd9d3 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes angular#7544.
@crisbeto crisbeto mentioned this issue Oct 5, 2017
Merged
crisbeto added a commit to crisbeto/material2 that referenced this issue Oct 6, 2017
@crisbeto
refactor(portal): rename PortalHost to PortalOutlet
b576868 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes angular#7544.
jelbourn pushed a commit that referenced this issue Oct 26, 2017
@crisbeto @jelbourn
refactor(portal): rename PortalHost to PortalOutlet
7c45e3d 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes #7544.
jelbourn pushed a commit to crisbeto/material2 that referenced this issue Oct 27, 2017
@crisbeto @jelbourn
refactor(portal): rename PortalHost to PortalOutlet
617e9b0 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes angular#7544.
@jelbourn jelbourn mentioned this issue Oct 27, 2017
Merged
mmalerba pushed a commit that referenced this issue Oct 30, 2017
@crisbeto @mmalerba
refactor(portal): rename PortalHost to PortalOutlet (#7546)
00de3f6 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes #7544.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P2 The issue is important to a large percentage of users, with a workaround
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

refactor(portal): rename PortalHost to PortalOutlet crisbeto/material2
2 participants
@jelbourn @crisbeto