Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(portal): rename PortalHost to PortalOutlet #7546

Merged
merged 1 commit into from
Oct 30, 2017
Merged

refactor(portal): rename PortalHost to PortalOutlet #7546

merged 1 commit into from
Oct 30, 2017

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 5, 2017

Renames the PortalHost and related symbols to PortalOutlet for consistency with core.

Fixes #7544.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 5, 2017
jelbourn
jelbourn approved these changes Oct 5, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 5, 2017
@kara
Copy link
Contributor

kara commented Oct 6, 2017

@crisbeto Rebase?

@kara kara assigned crisbeto and unassigned jelbourn Oct 6, 2017
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Oct 6, 2017
@crisbeto
Copy link
Member Author

crisbeto commented Oct 6, 2017

Rebased.

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Oct 6, 2017
@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note labels Oct 24, 2017
@jelbourn
Copy link
Member

Caretaker note: there are very few locations in Google that need to be updated for this

@crisbeto @jelbourn
refactor(portal): rename PortalHost to PortalOutlet
617e9b0 
Renames the `PortalHost` and related symbols to `PortalOutlet` for consistency with core.

Fixes angular#7544.
@mmalerba mmalerba merged commit 00de3f6 into angular:master Oct 30, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

@josephperrott josephperrott Awaiting requested review from josephperrott

Assignees

@crisbeto crisbeto

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename PortalHost to PortalOutlet
5 participants
@crisbeto @kara @jelbourn @googlebot @mmalerba