Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(radio): unable to click to select button if text is marked #14967

Merged
merged 1 commit into from
Feb 1, 2019
Merged

fix(radio): unable to click to select button if text is marked #14967

merged 1 commit into from
Feb 1, 2019

Conversation

crisbeto
Copy link
Member

Fixes not being able to select a radio button by clicking on it, if part of the text of the label is marked.

Fixes #14753.

@crisbeto
fix(radio): unable to click to select button if text is marked
0d8f0ca 
Fixes not being able to select a radio button by clicking on it, if part of the text of the label is marked.

Fixes angular#14753.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jan 26, 2019
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 26, 2019
jelbourn
jelbourn approved these changes Jan 29, 2019
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jan 29, 2019
@mmalerba mmalerba merged commit 5846038 into angular:master Feb 1, 2019
crisbeto added a commit to crisbeto/material2 that referenced this pull request Feb 2, 2019
@crisbeto
fix(checkbox): unable to click to select if text is marked
c1e111e 
Fixes not being able to select a checkbox button by clicking on it, if part of the text of the label is marked. Also fixes text inside the checkbox being marked if the user clicks on it quickly.

Relates to angular#14967.
@crisbeto crisbeto mentioned this pull request Feb 2, 2019
Merged
mmalerba added a commit that referenced this pull request Feb 4, 2019
@mmalerba
Revert "fix(radio): unable to click to select button if text is marked (
9db8f63 
#14967)"

This reverts commit 5846038.
mmalerba added a commit that referenced this pull request Feb 4, 2019
@mmalerba
Revert "perf(focus-monitor): avoid triggering change detection if the…
bc6b700 
…re are no subscribers to stream" (#15076)

* Revert "fix(radio): unable to click to select button if text is marked (#14967)"

This reverts commit 5846038.

* Revert "perf(focus-monitor): avoid triggering change detection if there are no subscribers to stream (#14964)"

This reverts commit 085bbb7.
mmalerba pushed a commit that referenced this pull request Feb 4, 2019
@crisbeto @mmalerba
fix(radio): unable to click to select button if text is marked (#14967)
81380d2 
Fixes not being able to select a radio button by clicking on it, if part of the text of the label is marked.

Fixes #14753.
mmalerba added a commit that referenced this pull request Feb 4, 2019
@mmalerba
Revert "perf(focus-monitor): avoid triggering change detection if the…
e6500fb 
…re are no subscribers to stream" (#15076)

* Revert "fix(radio): unable to click to select button if text is marked (#14967)"

This reverts commit 5846038.

* Revert "perf(focus-monitor): avoid triggering change detection if there are no subscribers to stream (#14964)"

This reverts commit 085bbb7.
jelbourn pushed a commit that referenced this pull request Feb 5, 2019
@crisbeto @jelbourn
fix(checkbox): unable to click to select if text is marked (#15062)
20c27c7 
Fixes not being able to select a checkbox button by clicking on it, if part of the text of the label is marked. Also fixes text inside the checkbox being marked if the user clicks on it quickly.

Relates to #14967.
jelbourn pushed a commit that referenced this pull request Feb 11, 2019
@crisbeto @jelbourn
fix(checkbox): unable to click to select if text is marked (#15062)
4819c5b 
Fixes not being able to select a checkbox button by clicking on it, if part of the text of the label is marked. Also fixes text inside the checkbox being marked if the user clicks on it quickly.

Relates to #14967.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radiobutton doesn't focus when selecting the associated label
4 participants
@crisbeto @jelbourn @googlebot @mmalerba