perf(focus-monitor): avoid triggering change detection if there are no subscribers to stream #14964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o subscribers to stream Currently we have an `NgZone.run` call on each `focus` and `blur` event of a monitored event in order to bring its subscribers into the `NgZone`, however this means that we're also triggering change detection to any consumers that aren't subscribed to changes (e.g. `mat-button` only cares about the classes being applied). These changes move around some logic so that the `NgZone.run` is only hit if somebody has subscribed to the observable.
googlebot
added
the
cla: yes
mmalerba
added
pr: lgtm
action: merge
mmalerba
approved these changes
Jan 25, 2019
mmalerba
pushed a commit
that referenced
this pull request
Feb 4, 2019
…o subscribers to stream (#14964) Currently we have an `NgZone.run` call on each `focus` and `blur` event of a monitored element in order to bring its subscribers into the `NgZone`, however this means that we're also triggering change detection to any consumers that aren't subscribed to changes (e.g. `mat-button` only cares about the classes being applied). These changes move around some logic so that the `NgZone.run` is only hit if somebody has subscribed to the observable.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have an
NgZone.runcall on eachfocusandblurevent of a monitored element in order to bring its subscribers into theNgZone, however this means that we're also triggering change detection to any consumers that aren't subscribed to changes (e.g.mat-buttononly cares about the classes being applied). These changes move around some logic so that theNgZone.runis only hit if somebody has subscribed to the observable.