perf(cdk/a11y): avoid triggering change detection if there are no subscribers to stream #15077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
merge: caretaker note
googlebot
added
the
cla: yes
crisbeto
added
the
P3
crisbeto
force-pushed
the
focus-monitor-change-detection-again
branch
from
bb3ff4d to
d5ca30d
Compare
crisbeto
force-pushed
the
focus-monitor-change-detection-again
branch
from
d5ca30d to
6b96ee6
Compare
crisbeto
force-pushed
the
focus-monitor-change-detection-again
branch
from
6b96ee6 to
f3ce4d8
Compare
crisbeto
changed the title
crisbeto
force-pushed
the
focus-monitor-change-detection-again
branch
from
f3ce4d8 to
cac70ac
Compare
andrewseguin
added
needs rebase
and removed
cla: yes
…scribers to stream Currently we have an `NgZone.run` call on each `focus` and `blur` event of a monitored event in order to bring its subscribers into the `NgZone`, however this means that we're also triggering change detection to any consumers that aren't subscribed to changes (e.g. `mat-button` only cares about the classes being applied). These changes move around some logic so that the `NgZone.run` is only hit if somebody has subscribed to the observable.
crisbeto
force-pushed
the
focus-monitor-change-detection-again
branch
from
cac70ac to
81c4c97
Compare
1 task
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
…scribers to stream (angular#15077) Currently we have an `NgZone.run` call on each `focus` and `blur` event of a monitored event in order to bring its subscribers into the `NgZone`, however this means that we're also triggering change detection to any consumers that aren't subscribed to changes (e.g. `mat-button` only cares about the classes being applied). These changes move around some logic so that the `NgZone.run` is only hit if somebody has subscribed to the observable.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a resubmit of #14964.
Currently we have an
NgZone.runcall on eachfocusandblurevent of a monitored event in order to bring its subscribers into theNgZone, however this means that we're also triggering change detection to any consumers that aren't subscribed to changes (e.g.mat-buttononly cares about the classes being applied). These changes move around some logic so that theNgZone.runis only hit if somebody has subscribed to the observable.Caretaker note: this PR had to be reverted before (#15076) because there was an app that depended on the extra change detections. We may have to investigate further before we can merge this in again.