Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/button-toggle): animate checkbox #30025

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

crisbeto
Copy link
Member

Currently the checkbox inside button toggle is a bit jarring. These changes add an animation to it.

@crisbeto crisbeto added the target: rc This PR is targeted for the next release-candidate label Nov 15, 2024
@crisbeto crisbeto requested a review from a team as a code owner November 15, 2024 10:57
@crisbeto crisbeto requested review from mmalerba and andrewseguin and removed request for a team November 15, 2024 10:57
@crisbeto crisbeto force-pushed the buttont-toggle-animation branch from bebc398 to baf981a Compare November 18, 2024 09:06
Currently the checkbox inside button toggle is a bit jarring. These changes add an animation to it.
@crisbeto crisbeto force-pushed the buttont-toggle-animation branch from baf981a to ebfd20a Compare November 18, 2024 09:55
@crisbeto crisbeto added target: patch This PR is targeted for the next patch release dev-app preview When applied, previews of the dev-app are deployed to Firebase and removed target: rc This PR is targeted for the next release-candidate labels Nov 18, 2024
@crisbeto crisbeto removed the request for review from mmalerba November 20, 2024 18:12
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Nov 20, 2024
Copy link

Deployed dev-app for ebfd20a to: https://ng-dev-previews-comp--pr-angular-components-30025-dev-2m2k6jt7.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

@crisbeto crisbeto merged commit 00959ec into angular:main Nov 20, 2024
24 of 27 checks passed
crisbeto added a commit that referenced this pull request Nov 20, 2024
Currently the checkbox inside button toggle is a bit jarring. These changes add an animation to it.

(cherry picked from commit 00959ec)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
action: merge The PR is ready for merge by the caretaker dev-app preview When applied, previews of the dev-app are deployed to Firebase target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants