Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose version object in releases #4962

Merged
merged 1 commit into from
Jul 27, 2017

Conversation

devversion
Copy link
Member

  • In releases there will be a constant called VERSION that holds the current version of the installed package (material or cdk)
  • This is similar as for every @angular package like core, forms, compiler.

@devversion devversion requested a review from jelbourn June 4, 2017 18:58
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2017
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn
Copy link
Member

jelbourn commented Jun 5, 2017

Before we merge this, I need to talk to @vikerman about how this version gets updated for Angular when doing the sync into Google.

@devversion devversion force-pushed the feat/expose-version-object branch 2 times, most recently from 3bd323e to c6fbbf7 Compare June 8, 2017 21:59
@devversion
Copy link
Member Author

Rebased.

@ThomasBurleson
Copy link

I love this PR. Need this in Flex-Layout!

@devversion devversion force-pushed the feat/expose-version-object branch 2 times, most recently from 99112f9 to 8d6bc8c Compare July 1, 2017 08:05
@devversion
Copy link
Member Author

@jelbourn Any updates on this one?

@jelbourn
Copy link
Member

Every time I remember it @vikerman is away from his desk.

@jelbourn
Copy link
Member

Finally followed up on this- no action needed on your part. Will be good to merge after my cdk entry-points PR (version will be the only thing under @angular/cdk directly)

@devversion
Copy link
Member Author

@jelbourn Rebased. Please have another look.

@@ -0,0 +1,32 @@
import {readFileSync, writeFileSync} from 'fs';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this code exist twice?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. Looks like the old one before the build changes is still there after rebasing.

Copy link
Member Author

@devversion devversion Jul 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done (removed it)

* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

fileContent = fileContent.replace(versionPlaceholderRegex, buildConfig.projectVersion);

writeFileSync(filePath, fileContent);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this writeFileSync need 'utf-8'?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

writeFileSync always defaults to UTF-8 as encoding (reference)

@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jul 26, 2017
@andrewseguin andrewseguin merged commit 3bfe7f0 into angular:master Jul 27, 2017
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Jul 27, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Jul 28, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.
andrewseguin pushed a commit that referenced this pull request Jul 29, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Jul 31, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.
tinayuangao pushed a commit that referenced this pull request Aug 1, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.
tinayuangao pushed a commit to tinayuangao/material2 that referenced this pull request Aug 1, 2017
* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.
tinayuangao added a commit that referenced this pull request Aug 1, 2017
* real world example

* remove roles

* feat: expose version object in releases (#4962)

* In releases there will be a constant called `VERSION` that holds the current version of the installed package (material or cdk)
* This is similar as for every @angular package like core, forms, compiler.

Add accessibility demo page for grid list

.

* change header and add roles
@devversion devversion deleted the feat/expose-version-object branch November 11, 2017 10:22
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants