Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move coercing to cdk package #5025

Merged
merged 1 commit into from
Jun 22, 2017
Merged

feat: move coercing to cdk package #5025

merged 1 commit into from
Jun 22, 2017

Conversation

devversion
Copy link
Member

@devversion devversion commented Jun 8, 2017 •
edited
Loading

  • Moves the coercing to the CDK package

Note: The version placeholder in the src/lib/package.json will be replaced automatically if #4962 is merged.

@devversion devversion requested a review from jelbourn June 8, 2017 15:12
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 8, 2017
jelbourn
jelbourn approved these changes Jun 8, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jun 8, 2017
@jelbourn
Copy link
Member

jelbourn commented Jun 8, 2017

For caretaker: this will need new build rules
(@andrewseguin)

@jelbourn jelbourn removed the action: merge The PR is ready for merge by the caretaker label Jun 8, 2017
@jelbourn
Copy link
Member

jelbourn commented Jun 8, 2017

Removing "merge-ready" until we release beta.7 (should be today)

@willshowell willshowell mentioned this pull request Jun 9, 2017
Closed
@devversion devversion added action: merge The PR is ready for merge by the caretaker and removed pr: needs rebase labels Jun 14, 2017
@kara kara added pr: needs rebase and removed action: merge The PR is ready for merge by the caretaker labels Jun 16, 2017
@kara kara assigned devversion and unassigned jelbourn Jun 16, 2017
@kara
Copy link
Contributor

kara commented Jun 16, 2017

@devversion Can you rebase, please?

@kara kara added the merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note label Jun 16, 2017
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Jun 21, 2017
@devversion devversion force-pushed the feat/move-coercing-to-cdk branch 3 times, most recently from 76409d7 to c58c43c Compare June 22, 2017 17:47
@devversion
feat: move coercing to cdk package
11af1c9 
* Moves the coercing to the CDK package
@jelbourn jelbourn merged commit 17cc4a1 into angular:master Jun 22, 2017
@devversion devversion mentioned this pull request Jul 6, 2017
Merged
@devversion devversion deleted the feat/move-coercing-to-cdk branch November 11, 2017 10:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@devversion devversion

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement merge: caretaker note Alert the caretaker performing the merge to check the PR for an out of normal action needed or note
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devversion @jelbourn @kara @googlebot @andrewseguin