fix(drawer): infinite loop when two-way opened binding is toggled mid-animation #8872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
mmalerba
approved these changes
Dec 7, 2017
src/lib/sidenav/drawer.ts
Outdated
| @@ -195,7 +195,7 @@ export class MatDrawer implements AfterContentInit, AfterContentChecked, OnDestr | |||
| _animationState: 'open-instant' | 'open' | 'void' = 'void'; | |||
|
|
|||
| /** Event emitted when the drawer open state is changed. */ | |||
| @Output() openedChange: EventEmitter<boolean> = new EventEmitter<boolean>(); | |||
| @Output() openedChange: EventEmitter<boolean> = new EventEmitter<boolean>(true); | |||
There was a problem hiding this comment.
...(/* isAsync */ true) since it kind of looks like initializing open to true
crisbeto
force-pushed
the
8869/drawer-infinite-loop
branch
from
17917a5
to
8ab5de6
Compare
…-animation As of angular@004e0fe the drawer supports a two-way binding on the `opened` property, however because the `openedChange` emits at the end of the animation and two-way bindings invoke their setter which then trigger an animation which in turn invokes `openedChange`, there is the potential for an infinite loop if the user changes the `opened` state mid-animation. These changes avoid the issue by turning the `openedChanged` into an async stream and emitting the current value at the end of the animation, rather than determining the value based on the animation state. Fixes angular#8869.
crisbeto
force-pushed
the
8869/drawer-infinite-loop
branch
from
8ab5de6
to
278e191
Compare
crisbeto
added
action: merge
|
Caretaker note: this might cause some |
andrewseguin
pushed a commit
that referenced
this pull request
Dec 19, 2017
…-animation (#8872) As of 004e0fe the drawer supports a two-way binding on the `opened` property, however because the `openedChange` emits at the end of the animation and two-way bindings invoke their setter which then trigger an animation which in turn invokes `openedChange`, there is the potential for an infinite loop if the user changes the `opened` state mid-animation. These changes avoid the issue by turning the `openedChanged` into an async stream and emitting the current value at the end of the animation, rather than determining the value based on the animation state. Fixes #8869.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of 004e0fe the drawer supports a two-way binding on the
openedproperty, however because theopenedChangeemits at the end of the animation and two-way bindings invoke their setter which then trigger an animation which in turn invokesopenedChange, there is the potential for an infinite loop if the user changes theopenedstate mid-animation. These changes avoid the issue by turning theopenedChangedinto an async stream and emitting the current value at the end of the animation, rather than determining the value based on the animation state.Fixes #8869.